gh issue create \
  --title "Editor + REST API for encoder templates" \
  --label enhancement \
  --body "$(cat <<'EOF'
v2 of the encoder-templates feature. Move the hand-curated data into a new EncoderTemplates DB table, expose CRUD via a CakePHP REST API, add an Options-page editor (list / edit / copy / delete), and rename the v1 mixed Preset/Template terminology to consistently use Template.

Spec: docs/superpowers/specs/2026-05-02-encoder-templates-editor-design.md
Plan: docs/superpowers/plans/2026-05-02-encoder-templates-editor.md
EOF
)"

git branch -m encoder-presets-editor <N>-encoder-templates-editor

git mv web/skins/classic/views/js/monitor-encoder-presets.js \
        web/skins/classic/views/js/monitor-encoder-templates.js

git mv tests/js/encoder-presets.test.js \
        tests/js/encoder-templates.test.js

grep -n "Preset\|preset" web/skins/classic/views/js/monitor-encoder-templates.js | grep -v "this\\.encoderSel\\|preset_\\|EncoderPreset\\|key.*preset\\|val.*preset\\|preset=\\|preset:\\|the preset\\|preset's"

node tests/js/encoder-templates.test.js

<script src="<?php echo cache_bust('skins/classic/views/js/monitor-encoder-templates.js') ?>"></script>

node tests/js/encoder-templates.test.js
npx eslint web/skins/classic/views/js/monitor-encoder-templates.js
php -l web/skins/classic/views/monitor.php web/lang/en_gb.php

git add -A
git commit -m "$(cat <<'EOF'
refactor: rename Preset to Template throughout encoder-templates feature refs #<N>

The v1 feature used "Templates" for the file/class/global but "Preset"
for DOM ids, JS module file, namespace, test file, and the inner data
shape. Make the terminology consistent so v2 (the editor) doesn't
inherit the inconsistency.

No behavioural changes — purely string substitution + file renames.
The 23-test pure-function suite still passes; ESLint clean.

Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
EOF
)"

const TEMPLATES_FIXTURE = {
  libx264: {
    valid_keys: ['preset', 'crf', 'g', 'profile', 'pix_fmt'],
    templates: [],
  },
  h264_nvenc: {
    valid_keys: ['preset', 'rc', 'cq', 'g', 'profile', 'pix_fmt'],
    templates: [],
  },
};

console.log('\nfindTemplateByName (cross-encoder match)');
const NAME_FIXTURE = {
  libx264: {
    valid_keys: ['preset'],
    templates: [
      {id: 1, name: 'Balanced',   description: '', params: {preset: 'fast'}},
      {id: 2, name: 'Archival',   description: '', params: {preset: 'slow'}},
    ],
  },
  libx265: {
    valid_keys: ['preset'],
    templates: [
      {id: 3, name: 'Balanced',   description: '', params: {preset: 'fast'}},
      {id: 4, name: 'archival',   description: '', params: {preset: 'slow'}}, // lowercase variant
    ],
  },
};
test('findTemplateByName: exact match', () => {
  const t = ZM.findTemplateByName('libx265', 'Balanced', NAME_FIXTURE);
  assert.strictEqual(t.id, 3);
});
test('findTemplateByName: case-insensitive match', () => {
  const t = ZM.findTemplateByName('libx265', 'Archival', NAME_FIXTURE);
  assert.strictEqual(t.id, 4);
});
test('findTemplateByName: no match returns null', () => {
  const t = ZM.findTemplateByName('libx265', 'Low Power', NAME_FIXTURE);
  assert.strictEqual(t, null);
});
test('findTemplateByName: unknown encoder returns null', () => {
  const t = ZM.findTemplateByName('libsvtav1', 'Balanced', NAME_FIXTURE);
  assert.strictEqual(t, null);
});

node tests/js/encoder-templates.test.js

  function presetWithKind(encoder, kind) {
    if (!kind) return null;
    const t = getTemplates()[encoder];
    if (!t || !Array.isArray(t.templates)) return null;
    for (let i = 0; i < t.templates.length; i++) {
      if (t.templates[i].kind === kind) return t.templates[i];
    }
    return null;
  }

  function findTemplateByName(encoder, name, templatesArg) {
    if (!name) return null;
    const all = templatesArg || getTemplates();
    const t = all[encoder];
    if (!t || !Array.isArray(t.templates)) return null;
    const target = String(name).toLowerCase();
    for (let i = 0; i < t.templates.length; i++) {
      if (String(t.templates[i].name).toLowerCase() === target) return t.templates[i];
    }
    return null;
  }

  function onEncoderChange() {
    const encoderSel = document.getElementById('ZmEncoder');
    if (!encoderSel) return;
    const previousKind = lastAppliedKind;
    repopulatePresets();
    runLint();
    if (!previousKind) return;
    const match = presetWithKind(encoderSel.value, previousKind);
    if (!match) return;
    ...

  function onEncoderChange() {
    const encoderSel = document.getElementById('ZmEncoder');
    if (!encoderSel) return;
    const previousName = lastAppliedName;
    repopulateTemplates();
    runLint();
    if (!previousName) return;
    const match = findTemplateByName(encoderSel.value, previousName);
    if (!match) return;
    const msg = 'You had a "' + previousName + '" template selected. ' +
                'Apply ' + match.name + ' for ' + encoderSel.value + '?';
    if (window.confirm(msg)) {
      applyTemplate(match.id);
    }
  }

    presetSel.addEventListener('change', function() {
      const opt = presetSel.options[presetSel.selectedIndex];
      if (opt) lastAppliedName = opt.textContent;
    });

    for (let i = 0; i < t.templates.length; i++) {
      const tmpl = t.templates[i];
      const opt = document.createElement('option');
      opt.value = tmpl.id;
      opt.textContent = tmpl.name;
      if (tmpl.description) opt.title = tmpl.description;
      presetSel.appendChild(opt);
    }

  const api = {
    parseParams: parseParams,
    mergeParams: mergeParams,
    serializeParams: serializeParams,
    lint: lint,
    findTemplateByName: findTemplateByName,
    init: init,
  };

node tests/js/encoder-templates.test.js
npx eslint web/skins/classic/views/js/monitor-encoder-templates.js
php -l web/includes/EncoderTemplates.php

git add -A
git commit -m "$(cat <<'EOF'
refactor: switch cross-encoder template match from kind to case-insensitive Name refs #<N>

The v1 cross-encoder dialog used a 'kind' enum to find an analogue
template on the new encoder. The v2 schema drops kind in favour of a
unique (Encoder, Name) constraint, so we can match by name with a
case-insensitive comparison instead. New helper findTemplateByName
replaces presetWithKind. Helper functions are also renamed for
consistency: repopulatePresets -> repopulateTemplates, applyPreset
-> applyTemplate, findPreset -> findTemplate, lastAppliedKind ->
lastAppliedName.

The PHP data file is updated in lockstep so the static array still
matches the JS shape; Task 4 replaces it with a DB-backed wrapper.

Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
EOF
)"

--
-- Table structure for table `EncoderTemplates`
--

DROP TABLE IF EXISTS `EncoderTemplates`;
CREATE TABLE `EncoderTemplates` (
  `Id` int(10) unsigned NOT NULL AUTO_INCREMENT,
  `Encoder` varchar(32) NOT NULL,
  `Name` varchar(64) NOT NULL,
  `Description` text,
  `Params` text NOT NULL DEFAULT '',
  PRIMARY KEY (`Id`),
  KEY `Encoder` (`Encoder`),
  UNIQUE KEY `Encoder_Name` (`Encoder`, `Name`)
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4;

INSERT IGNORE INTO EncoderTemplates (Encoder, Name, Description, Params) VALUES
('libx264', 'Balanced',
 '1080p recording with reasonable CPU cost. Good default for most cameras.',
 'preset=fast\ncrf=23\ng=30\nprofile=high\npix_fmt=yuv420p'),
('libx264', 'Archival (high quality)',
 'Slow encode for archival storage; substantially smaller files at higher CPU cost.',
 'preset=slow\ncrf=20\ng=30\nprofile=high\npix_fmt=yuv420p'),
('libx264', 'Low CPU',
 'Highest encoding speed for slow CPUs; quality and file size trade off.',
 'preset=ultrafast\ncrf=26\ng=30\nprofile=baseline\npix_fmt=yuv420p'),

('libx265', 'Balanced',
 '1080p HEVC recording with reasonable CPU cost. Significantly smaller files than x264 at similar quality.',
 'preset=fast\ncrf=25\ng=30\nprofile=main\npix_fmt=yuv420p'),
('libx265', 'Archival (high quality)',
 'Slow HEVC encode for archival storage.',
 'preset=slow\ncrf=22\ng=30\nprofile=main\npix_fmt=yuv420p'),
('libx265', 'Low CPU',
 'Highest HEVC encoding speed for slow CPUs.',
 'preset=ultrafast\ncrf=28\ng=30\nprofile=main\npix_fmt=yuv420p'),

('h264_nvenc', 'Balanced',
 '1080p H.264 on NVIDIA GPU; sane vbr+cq defaults, no B-frames for low latency.',
 'preset=p4\nrc=vbr\ncq=23\ng=30\nbf=0\nprofile=high\npix_fmt=nv12'),
('h264_nvenc', 'Low Power',
 'Faster preset for thermally-constrained NVIDIA hardware.',
 'preset=p1\nrc=vbr\ncq=26\ng=30\nbf=0\nprofile=high\npix_fmt=nv12'),

('hevc_nvenc', 'Balanced',
 '1080p HEVC on NVIDIA GPU; sane vbr+cq defaults, no B-frames.',
 'preset=p4\nrc=vbr\ncq=28\ng=30\nbf=0\nprofile=main\npix_fmt=nv12'),
('hevc_nvenc', 'Low Power',
 'Faster preset for thermally-constrained NVIDIA hardware.',
 'preset=p1\nrc=vbr\ncq=30\ng=30\nbf=0\nprofile=main\npix_fmt=nv12'),

('h264_vaapi', 'Balanced',
 '1080p H.264 via VA-API (Intel/AMD/Mesa); no B-frames.',
 'rc_mode=CQP\nqp=24\ng=30\nbf=0\nprofile=high\npix_fmt=nv12'),
('h264_vaapi', 'Low Power',
 'Lower-quality VA-API encode using the low_power codepath.',
 'rc_mode=CQP\nqp=27\ng=30\nbf=0\nprofile=high\npix_fmt=nv12\nlow_power=1'),

('hevc_vaapi', 'Balanced',
 '1080p HEVC via VA-API; no B-frames.',
 'rc_mode=CQP\nqp=27\ng=30\nbf=0\nprofile=main\npix_fmt=nv12'),
('hevc_vaapi', 'Low Power',
 'Lower-quality HEVC VA-API encode using the low_power codepath.',
 'rc_mode=CQP\nqp=30\ng=30\nbf=0\nprofile=main\npix_fmt=nv12\nlow_power=1');

--
-- Add EncoderTemplates table for v2 of the encoder-templates feature.
--

CREATE TABLE IF NOT EXISTS `EncoderTemplates` (
  `Id` int(10) unsigned NOT NULL AUTO_INCREMENT,
  `Encoder` varchar(32) NOT NULL,
  `Name` varchar(64) NOT NULL,
  `Description` text,
  `Params` text NOT NULL DEFAULT '',
  PRIMARY KEY (`Id`),
  KEY `Encoder` (`Encoder`),
  UNIQUE KEY `Encoder_Name` (`Encoder`, `Name`)
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4;

INSERT IGNORE INTO EncoderTemplates (Encoder, Name, Description, Params) VALUES
-- ... same 14 rows as Step 1 ...
;

echo "1.39.6" > version.txt

mysql -h unicron -u root -p --execute "EXPLAIN $(cat <<EOF
CREATE TABLE _encodertemplates_test (
  Id int(10) unsigned NOT NULL AUTO_INCREMENT,
  Encoder varchar(32) NOT NULL,
  Name varchar(64) NOT NULL,
  Description text,
  Params text NOT NULL DEFAULT '',
  PRIMARY KEY (Id),
  KEY Encoder (Encoder),
  UNIQUE KEY Encoder_Name (Encoder, Name)
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4;
DROP TABLE _encodertemplates_test;
EOF
)"

sudo -u www-data /usr/bin/zmupdate.pl --version=1.39.6 --user=root --pass=PASSWORD

mysql -h unicron -u zmuser -p zm -e "SELECT COUNT(*) FROM EncoderTemplates;"

git add db/zm_create.sql.in db/zm_update-1.39.6.sql version.txt
git commit -m "$(cat <<'EOF'
feat: add EncoderTemplates table and seed v1 templates refs #<N>

The v1 templates lived in a hand-curated PHP array. v2 moves them to
a new EncoderTemplates DB table so they're editable through the UI
and REST API. Seed the same 14 templates verbatim, with new
descriptions captured from the spec. The migration uses
INSERT IGNORE so partial-prior-seed states don't break upgrade.

UNIQUE (Encoder, Name) supports the case-insensitive cross-encoder
name match introduced in the previous commit.

version.txt -> 1.39.6.

Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
EOF
)"

<?php
//
// ZoneMinder Encoder Parameter Templates
// Copyright (C) 2026 ZoneMinder Inc.
//
namespace ZM;

class EncoderTemplates {
  // Static allow-list of recognised AVOption keys per encoder.
  // Used by the advisory lint in monitor-encoder-templates.js to flag
  // keys that ffmpeg will silently ignore. Hand-curated; opaque
  // pass-through options like x264-params/x265-params are listed but
  // their inner sub-options are not (ffmpeg's help text doesn't
  // enumerate them, and runtime introspection is deferred — see spec).
  private const VALID_KEYS = [
    'libx264' => [
      'preset', 'tune', 'profile', 'level', 'crf', 'qp', 'b',
      'maxrate', 'bufsize', 'g', 'keyint_min', 'sc_threshold',
      'bf', 'refs', 'pix_fmt', 'x264-params', 'x264opts',
    ],
    'libx265' => [
      'preset', 'tune', 'profile', 'level', 'crf', 'qp', 'b',
      'maxrate', 'bufsize', 'g', 'keyint_min', 'sc_threshold',
      'bf', 'refs', 'pix_fmt', 'x265-params',
    ],
    'h264_nvenc' => [
      'preset', 'tune', 'profile', 'level', 'rc', 'cq', 'qp', 'b',
      'maxrate', 'bufsize', 'g', 'bf', 'spatial-aq', 'temporal-aq',
      'rc-lookahead', 'pix_fmt', 'gpu', 'tuning_info',
    ],
    'hevc_nvenc' => [
      'preset', 'tune', 'profile', 'level', 'rc', 'cq', 'qp', 'b',
      'maxrate', 'bufsize', 'g', 'bf', 'spatial-aq', 'temporal-aq',
      'rc-lookahead', 'pix_fmt', 'gpu', 'tuning_info', 'tier',
    ],
    'h264_vaapi' => [
      'profile', 'level', 'rc_mode', 'qp', 'b', 'maxrate', 'bufsize',
      'g', 'bf', 'pix_fmt', 'low_power', 'idr_interval',
    ],
    'hevc_vaapi' => [
      'profile', 'level', 'rc_mode', 'qp', 'b', 'maxrate', 'bufsize',
      'g', 'bf', 'pix_fmt', 'low_power', 'idr_interval', 'tier',
    ],
  ];

  // Returns the templates dict consumed by monitor.js.php. Shape:
  //   { encoder: { valid_keys: [...], templates: [...] }, ... }
  // valid_keys come from VALID_KEYS; templates come from the DB.
  public static function all(): array {
    $byEncoder = [];
    foreach (self::VALID_KEYS as $enc => $keys) {
      $byEncoder[$enc] = ['valid_keys' => $keys, 'templates' => []];
    }
    $rows = dbFetchAll('SELECT Id, Encoder, Name, Description, Params FROM EncoderTemplates ORDER BY Encoder, Name');
    foreach ($rows as $row) {
      $enc = $row['Encoder'];
      if (!isset($byEncoder[$enc])) {
        // Unknown encoder (e.g. user added a row for libsvtav1).
        // No valid_keys -> lint says nothing.
        $byEncoder[$enc] = ['valid_keys' => [], 'templates' => []];
      }
      $byEncoder[$enc]['templates'][] = [
        'id'          => (int)$row['Id'],
        'name'        => $row['Name'],
        'description' => $row['Description'] ?? '',
        'params'      => self::paramsTextToObject($row['Params']),
      ];
    }
    return $byEncoder;
  }

  public static function validKeysFor(string $encoder): array {
    return self::VALID_KEYS[$encoder] ?? [];
  }

  // Convert "key=value\nkey=value" text to {key: value} for the
  // JS module's mergeParams. Mirrors the parseParams JS function.
  private static function paramsTextToObject(string $text): array {
    $out = [];
    foreach (preg_split('/[#,\n]/', $text) as $pair) {
      $idx = strpos($pair, '=');
      if ($idx === false) continue;
      $key = trim(substr($pair, 0, $idx));
      $val = trim(substr($pair, $idx + 1));
      if ($key !== '') $out[$key] = $val;
    }
    return $out;
  }
}

php -l web/includes/EncoderTemplates.php

php -r '
require "web/includes/Logger.php";
require "web/includes/database.php";
require "web/includes/EncoderTemplates.php";
$d = ZM\EncoderTemplates::all();
echo "encoders: ", count($d), "\n";
echo "libx264 templates: ", count($d["libx264"]["templates"]), "\n";
echo "first libx264 template name: ", $d["libx264"]["templates"][0]["name"], "\n";
echo "first libx264 template params keys: ", implode(",", array_keys($d["libx264"]["templates"][0]["params"])), "\n";
'

encoders: 6
libx264 templates: 3
first libx264 template name: Archival (high quality)
first libx264 template params keys: preset,crf,g,profile,pix_fmt

git add web/includes/EncoderTemplates.php
git commit -m "$(cat <<'EOF'
refactor: rewrite EncoderTemplates.php as DB-backed wrapper refs #<N>

ZM\EncoderTemplates::all() now reads templates from the DB (seeded by
the v1->v2 migration) rather than holding a hand-curated array.
valid_keys remains a static private constant — it's ffmpeg vocabulary,
not user data, and runtime introspection is deferred.

Adds a paramsTextToObject helper that mirrors the JS parseParams
semantics so the dict shape consumed by monitor.js.php is unchanged.

Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
EOF
)"

<?php
App::uses('AppModel', 'Model');

class EncoderTemplate extends AppModel {
  public $useTable = 'EncoderTemplates';
  public $primaryKey = 'Id';
  public $displayField = 'Name';
  public $recursive = -1;

  public $validate = array(
    'Encoder' => array(
      'notBlank' => array(
        'rule' => array('notBlank'),
        'message' => 'Encoder is required',
      ),
    ),
    'Name' => array(
      'notBlank' => array(
        'rule' => array('notBlank'),
        'message' => 'Name is required',
        'last' => true,
      ),
      'unique' => array(
        'rule' => array('isUniqueByEncoder'),
        'message' => 'A template with that name already exists for this encoder',
      ),
    ),
  );

  // Custom validator: Name must be unique within the row's Encoder.
  public function isUniqueByEncoder($field) {
    $name = $field['Name'];
    $encoder = isset($this->data[$this->alias]['Encoder']) ? $this->data[$this->alias]['Encoder'] : null;
    if (!$encoder) return true; // notBlank validator on Encoder will fail separately
    $conditions = array(
      'EncoderTemplate.Encoder' => $encoder,
      'EncoderTemplate.Name' => $name,
    );
    if (!empty($this->id)) {
      $conditions['EncoderTemplate.Id !='] = $this->id;
    }
    return $this->find('count', array('conditions' => $conditions)) === 0;
  }
}

php -l web/api/app/Model/EncoderTemplate.php

git add web/api/app/Model/EncoderTemplate.php
git commit -m "$(cat <<'EOF'
feat: add EncoderTemplate CakePHP model refs #<N>

Standard CakePHP 2.x model on the EncoderTemplates table. Validates
Encoder and Name as not blank, and Name as unique-per-Encoder via a
custom validator (CakePHP's built-in isUnique only handles single
columns).

Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
EOF
)"

<?php
App::uses('AppController', 'Controller');

class EncoderTemplatesController extends AppController {

  public $components = array('Paginator', 'RequestHandler');

  public function beforeFilter() {
    parent::beforeFilter();
  }

  public function index() {
    $this->EncoderTemplate->recursive = -1;
    $conditions = array();
    if (!empty($this->request->query['Encoder'])) {
      $conditions['EncoderTemplate.Encoder'] = $this->request->query['Encoder'];
    }
    $templates = $this->EncoderTemplate->find('all', array(
      'conditions' => $conditions,
      'order' => array('EncoderTemplate.Encoder' => 'ASC', 'EncoderTemplate.Name' => 'ASC'),
    ));
    $this->set(array(
      'encoderTemplates' => $templates,
      '_serialize' => array('encoderTemplates'),
    ));
  }

  public function view($id = null) {
    $this->EncoderTemplate->recursive = -1;
    if (!$this->EncoderTemplate->exists($id)) {
      throw new NotFoundException(__('Invalid encoder template'));
    }
    $template = $this->EncoderTemplate->find('first', array(
      'conditions' => array('EncoderTemplate.Id' => $id),
    ));
    $this->set(array(
      'encoderTemplate' => $template,
      '_serialize' => array('encoderTemplate'),
    ));
  }

  public function add() {
    if ($this->request->is('post')) {
      global $user;
      $canEdit = (!$user) || ($user->System() == 'Edit');
      if (!$canEdit) {
        throw new UnauthorizedException(__('Insufficient privileges'));
      }
      $this->EncoderTemplate->create();
      if ($this->EncoderTemplate->save($this->request->data)) {
        $this->set(array(
          'message' => 'Saved',
          'id'      => $this->EncoderTemplate->id,
          '_serialize' => array('message', 'id'),
        ));
      } else {
        $this->response->statusCode(422);
        $this->set(array(
          'message' => 'Error',
          'errors'  => $this->EncoderTemplate->validationErrors,
          '_serialize' => array('message', 'errors'),
        ));
      }
    }
  }

  public function edit($id = null) {
    global $user;
    $canEdit = (!$user) || ($user->System() == 'Edit');
    if (!$canEdit) {
      throw new UnauthorizedException(__('Insufficient privileges'));
    }
    if (!$this->EncoderTemplate->exists($id)) {
      throw new NotFoundException(__('Invalid encoder template'));
    }
    $this->EncoderTemplate->id = $id;
    if ($this->EncoderTemplate->save($this->request->data)) {
      $this->set(array(
        'message' => 'Saved',
        '_serialize' => array('message'),
      ));
    } else {
      $this->response->statusCode(422);
      $this->set(array(
        'message' => 'Error',
        'errors'  => $this->EncoderTemplate->validationErrors,
        '_serialize' => array('message', 'errors'),
      ));
    }
  }

  public function delete($id = null) {
    global $user;
    $canEdit = (!$user) || ($user->System() == 'Edit');
    if (!$canEdit) {
      throw new UnauthorizedException(__('Insufficient privileges'));
    }
    $this->EncoderTemplate->id = $id;
    if (!$this->EncoderTemplate->exists()) {
      throw new NotFoundException(__('Invalid encoder template'));
    }
    $this->request->allowMethod('post', 'delete');
    if ($this->EncoderTemplate->delete()) {
      $this->set(array(
        'message' => 'Deleted',
        '_serialize' => array('message'),
      ));
    } else {
      $this->response->statusCode(500);
      $this->set(array(
        'message' => 'Error',
        '_serialize' => array('message'),
      ));
    }
  }
}

php -l web/api/app/Controller/EncoderTemplatesController.php

git add web/api/app/Controller/EncoderTemplatesController.php
git commit -m "$(cat <<'EOF'
feat: add EncoderTemplates REST API controller refs #<N>

CakePHP 2.x controller mirroring ManufacturersController. Full CRUD:
index/view at viewer level (so the monitor edit page populates),
add/edit/delete gated on System=Edit privilege. index supports
filtering by ?Encoder=<name>. Validation errors return 422 with the
model's validationErrors array under the 'errors' key.

Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
EOF
)"

<li><a class="nav-link <?php echo $tab=='encoderTemplates' ? 'active' : '' ?>"
       href="?view=options&amp;tab=encoderTemplates"><?php echo translate('EncoderTemplates') ?></a></li>

} else if ($tab == 'encoderTemplates') {
  if (canView('System')) {
    include('_options_encoderTemplates.php');
  } else {
    $redirect = '?view=error';
    header('Location: '.$redirect);
  }

<?php
//
// ZoneMinder Options - Encoder Templates tab
//
require_once('includes/EncoderTemplates.php');
?>
<div id="options">
  <h2><?php echo translate('EncoderTemplates') ?></h2>
  <p><?php echo translate('EncoderTemplatesDescription') ?></p>
  <!-- Editor table + modal land in the next task -->
</div>

php -l web/skins/classic/views/options.php web/skins/classic/views/_options_menu.php web/skins/classic/views/_options_encoderTemplates.php

git add web/skins/classic/views/options.php web/skins/classic/views/_options_menu.php web/skins/classic/views/_options_encoderTemplates.php
git commit -m "$(cat <<'EOF'
feat: add EncoderTemplates Options tab skeleton refs #<N>

New top-level Options tab dispatched from options.php's tab chain to
a new _options_encoderTemplates.php include, gated on canView('System').
The next commit fills in the editor UI (table + modal); this commit is
just the navigation plumbing so the menu link works.

Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
EOF
)"

<?php
//
// ZoneMinder Options - Encoder Templates tab
//
require_once('includes/EncoderTemplates.php');

$encoderFilter = isset($_REQUEST['encoderFilter']) ? $_REQUEST['encoderFilter'] : '';
$canEdit = canEdit('System');
$dict = ZM\EncoderTemplates::all();

# Hardcoded encoder list — same as monitor.php
$encoders = array(
  '' => translate('AllEncoders'),
  'libx264' => 'libx264',
  'libx265' => 'libx265',
  'h264_nvenc' => 'h264_nvenc',
  'hevc_nvenc' => 'hevc_nvenc',
  'h264_vaapi' => 'h264_vaapi',
  'hevc_vaapi' => 'hevc_vaapi',
);
?>
<form name="encoderTemplatesForm" method="post" action="?">
  <div id="options">
    <input type="hidden" name="view" value="<?php echo $view ?>"/>
    <input type="hidden" name="tab" value="<?php echo $tab ?>"/>

    <div class="col">
      <label for="encoderFilter"><?php echo translate('FilterByEncoder') ?></label>
      <?php echo htmlSelect('encoderFilter', $encoders, $encoderFilter, array('id'=>'encoderFilter')) ?>
    </div>

    <div class="col button-block">
      <div id="contentButtons">
        <button type="button" id="NewEncoderTemplateBtn"<?php if (!$canEdit) echo ' disabled="disabled"' ?>><?php echo translate('AddNewEncoderTemplate') ?></button>
      </div>
    </div>

    <div class="wrapper-scroll-table">
      <div class="col">
        <table id="contentTable" class="table table-striped"
            data-click-to-select="true"
            data-show-export="true"
            data-show-columns="true"
            data-cookie="true"
            data-cookie-id-table="zmEncoderTemplatesTable"
            data-cookie-expire="2y"
        >
          <thead class="thead-highlight">
            <tr>
              <th data-sortable="true" class="colId"><?php echo translate('Id') ?></th>
              <th data-sortable="true" class="colEncoder"><?php echo translate('Encoder') ?></th>
              <th data-sortable="true" class="colName"><?php echo translate('Name') ?></th>
              <th data-sortable="true" class="colParams"><?php echo translate('Params') ?></th>
              <th class="colActions"><?php echo translate('Actions') ?></th>
            </tr>
          </thead>
          <tbody>
<?php
foreach ($dict as $enc => $entry) {
  foreach ($entry['templates'] as $tmpl) {
    $shortParams = mb_strimwidth(implode(' ', array_map(
        fn($k, $v) => $k.'='.$v, array_keys($tmpl['params']), array_values($tmpl['params']))),
        0, 60, '…');
?>
            <tr data-tid="<?php echo $tmpl['id'] ?>" data-encoder="<?php echo validHtmlStr($enc) ?>" data-name="<?php echo validHtmlStr($tmpl['name']) ?>">
              <td class="colId"><?php echo $tmpl['id'] ?></td>
              <td class="colEncoder"><?php echo validHtmlStr($enc) ?></td>
              <td class="colName"><?php echo validHtmlStr($tmpl['name']) ?></td>
              <td class="colParams" title="<?php echo validHtmlStr(implode("\n", array_map(
                  fn($k, $v) => $k.'='.$v, array_keys($tmpl['params']), array_values($tmpl['params'])))) ?>"><?php echo validHtmlStr($shortParams) ?></td>
              <td class="colActions">
                <button type="button" class="btn-edit" data-tid="<?php echo $tmpl['id'] ?>"<?php if (!$canEdit) echo ' disabled="disabled"' ?>><?php echo translate('Edit') ?></button>
                <button type="button" class="btn-copy" data-tid="<?php echo $tmpl['id'] ?>"<?php if (!$canEdit) echo ' disabled="disabled"' ?>><?php echo translate('Copy') ?></button>
                <button type="button" class="btn-delete" data-tid="<?php echo $tmpl['id'] ?>"<?php if (!$canEdit) echo ' disabled="disabled"' ?>><?php echo translate('Delete') ?></button>
              </td>
            </tr>
<?php
  }
}
?>
          </tbody>
        </table>
      </div>
    </div>
  </div>
</form>

<!-- Edit modal placeholder; populated client-side -->
<div id="encoderTemplateModalContainer"></div>

<script>
window.ZM_ENCODER_TEMPLATES = <?php echo json_encode(ZM\EncoderTemplates::all(), JSON_UNESCAPED_SLASHES); ?>;
</script>
<script src="<?php echo cache_bust('skins/classic/views/js/monitor-encoder-templates.js') ?>"></script>
<script src="<?php echo cache_bust('skins/classic/views/js/options-encoder-templates.js') ?>"></script>

php -l web/skins/classic/views/_options_encoderTemplates.php

git add web/skins/classic/views/_options_encoderTemplates.php
git commit -m "$(cat <<'EOF'
feat: render Encoder Templates editor table refs #<N>

Bootstrap-table list of all templates with Encoder filter dropdown,
per-row Edit / Copy / Delete buttons, and a New button. Renders the
templates dict via PHP, dumps it into window.ZM_ENCODER_TEMPLATES for
the JS module's lint integration. The modal HTML and the JS that
wires the buttons land in the next task.

Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
EOF
)"

<?php
// Modal for the EncoderTemplates editor.
// Called via /index.php?view=request&request=modal&modal=encoderTemplate&id=<id>
//   or with id=0 / no id for create mode.

if (!canEdit('System')) {
  ajaxError('Insufficient privileges');
  return;
}

$id = isset($_REQUEST['id']) ? (int)$_REQUEST['id'] : 0;
$tmpl = null;
if ($id) {
  $row = dbFetchOne('SELECT * FROM EncoderTemplates WHERE Id = ?', null, array($id));
  if (!$row) {
    ajaxError('Invalid template id');
    return;
  }
  $tmpl = $row;
}

$encoders = array(
  'libx264' => 'libx264',
  'libx265' => 'libx265',
  'h264_nvenc' => 'h264_nvenc',
  'hevc_nvenc' => 'hevc_nvenc',
  'h264_vaapi' => 'h264_vaapi',
  'hevc_vaapi' => 'hevc_vaapi',
);
?>
<div class="modal fade" id="EncoderTemplateModal" tabindex="-1" aria-labelledby="encoderTemplateModalTitle" aria-hidden="true">
  <div class="modal-dialog">
    <div class="modal-content">
      <div class="modal-header">
        <h5 class="modal-title" id="encoderTemplateModalTitle">
          <?php echo $tmpl ? translate('EditEncoderTemplate') : translate('NewEncoderTemplate') ?>
        </h5>
        <button type="button" class="close" data-dismiss="modal" aria-label="Close">
          <span aria-hidden="true">&times;</span>
        </button>
      </div>
      <div class="modal-body">
        <div id="encoderTemplateError" class="alert alert-danger" style="display:none"></div>
        <input type="hidden" id="EtId" value="<?php echo $tmpl ? $tmpl['Id'] : '' ?>"/>
        <div class="form-group">
          <label for="EtEncoder"><?php echo translate('Encoder') ?></label>
          <?php echo htmlSelect('EtEncoder', $encoders, $tmpl ? $tmpl['Encoder'] : 'libx264', array('id'=>'EtEncoder', $tmpl ? 'disabled' : '_' => 'disabled')) ?>
        </div>
        <div class="form-group">
          <label for="EtName"><?php echo translate('Name') ?></label>
          <input type="text" id="EtName" maxlength="64" value="<?php echo $tmpl ? validHtmlStr($tmpl['Name']) : '' ?>"/>
        </div>
        <div class="form-group">
          <label for="EtDescription"><?php echo translate('Description') ?></label>
          <textarea id="EtDescription" rows="2"><?php echo $tmpl ? validHtmlStr($tmpl['Description'] ?? '') : '' ?></textarea>
        </div>
        <div class="form-group">
          <label for="EtParams"><?php echo translate('Params') ?></label>
          <textarea id="EtParams" rows="6"><?php echo $tmpl ? validHtmlStr($tmpl['Params']) : '' ?></textarea>
          <div id="EtParamsDiagnostics" class="encoderParameterDiagnostics"></div>
        </div>
      </div>
      <div class="modal-footer">
        <button type="button" class="btn btn-secondary" data-dismiss="modal"><?php echo translate('Cancel') ?></button>
        <button type="button" class="btn btn-primary" id="EtSave"><?php echo translate('Save') ?></button>
      </div>
    </div>
  </div>
</div>

(function() {
  'use strict';

  function api(method, url, data, onSuccess, onError) {
    const opts = {
      url: url,
      method: method,
      dataType: 'json',
    };
    if (data) opts.data = data;
    $j.ajax(opts).done(onSuccess).fail(function(jqXHR) {
      onError(jqXHR.responseJSON || {message: jqXHR.statusText});
    });
  }

  function showModal(id) {
    const url = thisUrl + '?view=request&request=modal&modal=encoderTemplate' + (id ? '&id=' + id : '');
    $j.get(url).done(function(html) {
      $j('#encoderTemplateModalContainer').html(html);
      const $modal = $j('#EncoderTemplateModal');
      $modal.modal('show');
      bindModal(id);
    });
  }

  function bindModal(editingId) {
    $j('#EtParams').on('input', runLint);
    $j('#EtEncoder').on('change', runLint);
    $j('#EtSave').on('click', function() { saveModal(editingId); });
    runLint();
  }

  function runLint() {
    const encoder = $j('#EtEncoder').val();
    const text = $j('#EtParams').val();
    const parsed = ZM_EncoderTemplates.parseParams(text);
    const unknown = ZM_EncoderTemplates.lint(parsed, encoder, window.ZM_ENCODER_TEMPLATES);
    const $diag = $j('#EtParamsDiagnostics');
    if (!unknown.length) {
      $diag.hide().text('');
      return;
    }
    $diag.show().text('Note: ' + unknown.map(function(k) { return '`' + k + '`'; }).join(', ')
        + ' are not recognised options for `' + encoder + '` and will be ignored at runtime.');
  }

  function saveModal(editingId) {
    const data = {
      'EncoderTemplate[Encoder]':     $j('#EtEncoder').val(),
      'EncoderTemplate[Name]':        $j('#EtName').val(),
      'EncoderTemplate[Description]': $j('#EtDescription').val(),
      'EncoderTemplate[Params]':      $j('#EtParams').val(),
    };
    const url = '/api/encoderTemplates' + (editingId ? '/' + editingId : '') + '.json';
    const method = editingId ? 'PUT' : 'POST';
    api(method, url, data, function(resp) {
      if (resp.message === 'Saved') {
        $j('#EncoderTemplateModal').modal('hide');
        location.reload(); // simplest; the table re-renders from PHP next load
      } else {
        showError(resp);
      }
    }, showError);
  }

  function showError(resp) {
    const $err = $j('#encoderTemplateError');
    if (resp.errors) {
      const lines = [];
      for (const field in resp.errors) {
        for (const msg of resp.errors[field]) lines.push(field + ': ' + msg);
      }
      $err.text(lines.join('\n')).show();
    } else {
      $err.text(resp.message || 'Unknown error').show();
    }
  }

  function deleteRow(id, name, encoder) {
    if (!window.confirm("Delete template '" + name + "' for " + encoder + '?')) return;
    api('DELETE', '/api/encoderTemplates/' + id + '.json', null, function(resp) {
      if (resp.message === 'Deleted') location.reload();
      else showError(resp);
    }, showError);
  }

  function init() {
    $j('#NewEncoderTemplateBtn').on('click', function() { showModal(null); });
    $j('#contentTable').on('click', '.btn-edit', function() {
      showModal(parseInt($j(this).data('tid'), 10));
    });
    $j('#contentTable').on('click', '.btn-copy', function() {
      const id = parseInt($j(this).data('tid'), 10);
      // Copy = open create modal with prefilled fields. Simplest path:
      // open the modal with id (it loads the full row), then once shown,
      // null out the id and append " Copy" to the name.
      showModal(id);
      // Wait for modal-shown event before patching:
      $j('#EncoderTemplateModal').one('shown.bs.modal', function() {
        $j('#EtId').val('');
        $j('#EtName').val($j('#EtName').val() + ' Copy');
        // Re-enable the encoder select since this is now create mode
        $j('#EtEncoder').prop('disabled', false);
        // Re-bind save with editingId = null
        $j('#EtSave').off('click').on('click', function() { saveModal(null); });
      });
    });
    $j('#contentTable').on('click', '.btn-delete', function() {
      const $row = $j(this).closest('tr');
      deleteRow(parseInt($row.data('tid'), 10), $row.data('name'), $row.data('encoder'));
    });
    $j('#encoderFilter').on('change', function() {
      const enc = $j(this).val();
      $j('#contentTable tbody tr').each(function() {
        $j(this).toggle(!enc || $j(this).data('encoder') === enc);
      });
    });
  }

  $j(document).ready(init);
})();

npx eslint web/skins/classic/views/js/options-encoder-templates.js
php -l web/ajax/modals/encoderTemplate.php

git add web/ajax/modals/encoderTemplate.php web/skins/classic/views/js/options-encoder-templates.js web/ajax/modal.php
git commit -m "$(cat <<'EOF'
feat: encoder-templates editor modal + button wiring refs #<N>

Bootstrap modal that loads via /index.php?view=request&request=modal
&modal=encoderTemplate&id=<id>, and a small jQuery module that wires
the New / Edit / Copy / Delete buttons to the REST API. Reuses the
v1 lint helper from window.ZM_EncoderTemplates for the in-modal
Params textarea diagnostics.

Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
EOF
)"

'AddNewEncoderTemplate' => 'Add New Template',
'AllEncoders'           => 'All Encoders',
'EditEncoderTemplate'   => 'Edit Encoder Template',
'EncoderTemplates'      => 'Encoder Templates',
'EncoderTemplatesDescription' => 'Curated parameter sets for ffmpeg encoders. Apply one to a monitor\'s Encoder Parameters from the monitor edit page.',
'FilterByEncoder'       => 'Filter by Encoder',
'NewEncoderTemplate'    => 'New Encoder Template',
'Params'                => 'Params',

php -l web/lang/en_gb.php
grep -nE "EncoderTemplates|FilterByEncoder|AllEncoders|NewEncoderTemplate" web/lang/en_gb.php

git add web/lang/en_gb.php
git commit -m "$(cat <<'EOF'
feat: add v2 encoder-templates translation strings refs #<N>

EncoderTemplates page title, description, filter dropdown labels,
modal titles, and button labels.

Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
EOF
)"

db/zm_update-1.39.6.sql                                           → /usr/share/zoneminder/db/
db/zm_create.sql.in                                               → (only relevant for fresh installs; skip for upgrade test)
version.txt                                                       → /usr/share/zoneminder/
web/includes/EncoderTemplates.php                                 → www/includes/
web/api/app/Model/EncoderTemplate.php                             → www/api/app/Model/
web/api/app/Controller/EncoderTemplatesController.php             → www/api/app/Controller/
web/skins/classic/views/options.php                               → www/skins/classic/views/
web/skins/classic/views/_options_menu.php                         → www/skins/classic/views/
web/skins/classic/views/_options_encoderTemplates.php             → www/skins/classic/views/
web/skins/classic/views/monitor.php                               → www/skins/classic/views/
web/skins/classic/views/js/monitor-encoder-templates.js           → www/skins/classic/views/js/
web/skins/classic/views/js/monitor.js.php                         → www/skins/classic/views/js/
web/skins/classic/views/js/options-encoder-templates.js           → www/skins/classic/views/js/
web/ajax/modals/encoderTemplate.php                               → www/ajax/modals/
web/ajax/modal.php                                                → www/ajax/
web/lang/en_gb.php                                                → www/lang/

sudo -u www-data zmupdate.pl --version=1.39.6

mysql -h unicron -u zmuser -p zm -e "SELECT Encoder, Name FROM EncoderTemplates ORDER BY Encoder, Name"

JWT=...   # obtain via /api/host/login
curl -H "Authorization: Bearer $JWT" https://pseudo.connortechnology.com/api/encoderTemplates.json | jq '.encoderTemplates | length'

git status
git log --oneline master..HEAD

git checkout master
# v1 squashed commit was d58833d2a; the parent is the previous merge.
git reset --hard d58833d2a^   # back to 1413362d9 (the Range fix merge)
git merge --squash <N>-encoder-templates-editor   # this includes both v1 + v2 work

git commit -m "$(cat <<'EOF'
feat: encoder parameter templates with editor + REST API closes #4778 closes #<N>

Adds a curated, per-encoder parameter-template library to ZoneMinder:

- Monitor edit page: a new Template row above the EncoderParameters
  textarea offers per-encoder templates (Balanced / Archival / Low
  Power / Low CPU). Apply merges the template's params into the
  textarea, preserving user-only keys. Advisory lint flags option
  keys that aren't recognised for the selected encoder. Switching
  encoders offers a same-name template on the new encoder via a
  native confirm.

- Options page: a new Encoder Templates tab with full CRUD —
  list / edit / copy / delete — backed by a new CakePHP REST API
  at /api/encoderTemplates.

- Storage: a new EncoderTemplates DB table seeded with 14 shipped
  defaults across libx264/libx265/h264_nvenc/hevc_nvenc/h264_vaapi/
  hevc_vaapi. The table is mutable; ZM upgrades do not re-seed
  user-edited rows.

- valid_keys (the lint allow-list) stays in PHP code as ffmpeg
  vocabulary, not user data.

- Default params explicitly include pix_fmt to avoid the yuvj420p
  HEVC HW-decode rejection issue we hit earlier.

No C++ change. The textarea content is parsed by the existing
av_dict_parse_string call in src/zm_videostore.cpp.

Spec:  docs/superpowers/specs/2026-05-02-encoder-templates-editor-design.md
Plan:  docs/superpowers/plans/2026-05-02-encoder-templates-editor.md

Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
EOF
)"

git push origin master

git branch -d <N>-encoder-templates-editor