Back to Source Monitor

Shipped: Rails Audit & Refactoring

.vbw-planning/milestones/07-rails-audit-and-refactoring/SHIPPED.md

0.13.01.2 KB
Original Source

Shipped: Rails Audit & Refactoring

Archived: 2026-03-14 Phases: 7 (6 from prior audit + 1 new) Milestone: rails-audit-and-modal

Summary

Comprehensive Rails best practices audit and refactoring of the SourceMonitor engine. Addressed 49+ findings across models, controllers, jobs, views, and tests.

Phase 01-06 (Prior Audit Work)

  • Security fixes (authorization, .permit! replacement)
  • Model hardening (scopes, validations, query objects)
  • Controller refactoring (CRUD compliance, concern extraction)
  • Job/pipeline reliability (error classification, retry extraction, Result pattern)
  • View layer extraction (presenters, ViewComponents, icon system)
  • Test infrastructure (shared factories, conventions, sub-module tests)

Phase 07 (Rails Audit Round 2)

  • 5 plans, 25 tasks, ~28 commits
  • LogCleanupJob cascading deletes (data integrity)
  • 5 jobs slimmed to shallow delegation (5 new service classes)
  • health_status validation + DB default alignment
  • SetSource concern across 7 controllers
  • rescue_from RecordNotFound
  • StatusBadgeComponent replacing 12+ badge patterns
  • Modal accessibility (role=dialog, aria-modal, focus trapping)
  • Pagination test parallel-safety
  • 30 forwarding methods removed