Back to Source Monitor

Controller DRY & Robustness

.vbw-planning/milestones/07-rails-audit-and-refactoring/07-rails-audit-round-2/02-SUMMARY.md

0.13.01.1 KB
Original Source

Task 1: Extract SetSource Concern (M6)

  • Created SetSource concern with set_source finding by params[:source_id]
  • Included in 7 controllers, removed duplicated private methods
  • Commit: cb2cb2a

Task 2: Add rescue_from RecordNotFound + Guard fallback_user_id (M5, M7, L1)

  • Added rescue_from ActiveRecord::RecordNotFound to ApplicationController with Turbo-aware response
  • Guarded fallback_user_id behind Rails.env.development?
  • Documented wizard new action HTTP semantics
  • Commit: b2045dc

Task 3: Extract Source.enable_scraping! + Strong Params (M10, L2)

  • Moved bulk scrape enablement logic to Source.enable_scraping! class method
  • Added proper strong params wrapper in BulkScrapeEnablementsController
  • Commit: 6ccc157

Task 4: Document to_unsafe_h Usage (L7)

  • Added inline documentation explaining why to_unsafe_h is used (Ransack dynamic keys)
  • Commit: ecdae04

Task 5: Tailwind Classes in Controller (L4)

  • Addressed as part of StatusBadgeComponent extraction in Plan 04
  • No separate commit needed (cross-plan dependency resolved)