docs/development.md
The build instructions are in the building.md file. The testing instructions are in the testing.md file.
mise-en-place can be used to install the necessary
development tooling. After installing mise and registering mise with your
shell, go into your git checkout directory and mise trust -a the configuration
we ship. Afterwards mise install makes all the necessary tooling available.
Even if you do not want to use mise: .mise/config.toml contains a handy list of tools
to make available.
If you would like to automatically invoke autofix tasks (formatting, linting) before committing changes using a git pre-commit hook, set up the hook with the following command:
mise generate git-pre-commit --write --task=ci:autofix:fix
helper_cratesA set of crates that are somehow not strictly related to Slint, and that could be moved to their own repository and have their own version release at some point.
internalinternal contains code that isn't meant to be used directly by a user of Slint.
compilerThe main library for the compiler for .slint.
Nothing in there should depend on the runtime crates.
There is a test subdirectory that contains the syntax tests.
These tests allow you to test the proper error conditions.
The library crates that are used at runtime.
core is the main library. It's meant to be used for all front-ends. Ideally it should
be kept as small as possible. corelib-macros contains some procedural macro used by core library.backends contains the different backend for the different platform, separated from
core library. Currently there is just the gl backendinterpreter is the library used by the more dynamic languages backend to compile and
interpret .slint files. It links both against core library and the compiler libtoolscompiler is the tool to generate the target language (e.g. c++) from the .slint files for
frontend that have a compilation step and generated code.viewer is a tool that allow to open and view a .slint file.apiHere one can find the frontends for different languages.
testsThe integration test that are testing a bunch of .slint with different front-ends
See testing.md
examplesSome manual tests
There are some documentation comments in the code. HTML documentation can be generated with something like
cargo doc --document-private-items --no-deps --open
The documentation that lives on https://docs.slint.dev is rendered with Astro Starlight. See the ./astro/README.md file for details.
For a deep dive into certain aspects of slint's architecture and implementation, see the files in the development subdirectory.
We use a rather complex mechanism to expose internal data structures implemented in Rust to C++, in a way that allows us to provide a nice C++ API.
As a starting point, we recommend reading the blog entry we published about this:
https://slint.dev/blog/expose-rust-library-to-other-languages.html
What this article omits are how we invoke cbindgen and what kind of tweaks we apply on various levels:
The C++ library consists of four components:
slint-cpp cdylib created by cargo/rustc from api/cpp.api/cpp/include.cbindgen, via cargo xtask cbindgen.corrosion to call cargo and invoking cbindgen.cbindgenThe cbindgen xtask generates multiple header files for four different modules:
api/cpp/lib.rs.NativeButton, etc.slint_interpreter_internal.h.Typically the input to cbindgen is within ffi sub-modules in the corresponding input crates to cbindgen. These ffi modules are gated with #[cfg(feature = "ffi")].
Linear history is preferred over merge commits. Long lived features can live in feature branches and those can be integrated with merge commits, of course.
As a consequence, we typically integrate pull requests as "rebase and merge" or "squash and merge".
During code review, consider adding small commits on top to make it easier for the reviewer and contributor to track feedback and how the feedback was incorporated - rebase can tend to make it harder. It's perfectly fine to then squash these commits when the review phase is complete and approval is given.
Example:
A PR consists of three commits:
In the review phase, the reviewer suggests to make changes to the widget implementation and the documentation. Consider pushing these as follow-up fixes:
Finally, the PR is approved. As contributor, in your local branch, feel free to merge 4. into 1. and 5. into 2.:
(commits are real, sha1s are just examples)
As a first step, let's rebase our changes to make sure that there are no conflicts:
git rebase origin/master
This might run through without stopping. If there are merge conflicts to be resolved, git rebase will stop
and let you fix it. For instructions how to resolve the conflicts and continue, see Resolving merge conflicts after a Git rebase.
When your branch is rebased, proceed to squash the fixup commits. Start an interactive rebase that starts at the base commit:
$ git rebase -i origin/master
This launches the configured editor with the above list of commits, in the order as they will committed:
pick 82916bc2 Add new widget
pick e55bde4c Add documentation for new widget
pick 9bc8d203 Change example to use new widget
pick a6feda52 Fix an issue in widget found during review
pick 032032dc Fix a typo in the documentation
Let's merge 4. into 1. and 5. into 2. by changing the above:
pick 82916bc2 Add new widget
fixup a6feda52 Fix an issue in widget found during review
pick e55bde4c Add documentation for new widget
fixup 032032dc Fix a typo in the documentation
pick 9bc8d203 Change example to use new widget
Save and exit the editor.
Now git will start at the base commit, cherry-pick the first commit, and squash the "Fix an issue in widget found during code review"
change into the same commit. Use squash instead of fixup if you want to also further edit the commit message.
Save and exit the editor.
Now git continues to do the same with the second squash. Do as in the previous step and adjust the commit message to suit the original intent ("Add documentation for new widget").
Save and exit the editor. Rinse and repeat until the rebase is complete.
Use a tool like GitHub Desktop or gitk to take another look at the git history of commits.
Are all the fix-up commits merged with the original changes? Do the commit messages look okay?
If you need further changes, run $ git rebase -i origin/master again.
When the history is clean, double check that you're going to push to the right branch:
$ git push --dry-run -f
If that looks okay and targets the right branch for your PR, push with force:
$ git push -f