Back to Qwen Code

Auth & Security Model

docs/developers/daemon/12-auth-security.md

0.18.217.8 KB
Original Source

Auth & Security Model

Overview

qwen serve is a local daemon by default and an exposed surface in the wrong configuration. Its security model is layered so that misconfiguration fails closed:

  1. Bind — non-loopback bind without a bearer token refuses to start.
  2. Bearer authbearerAuth middleware with constant-time SHA-256 compare protects every route except /health on loopback (require_auth extends this to loopback and /health too).
  3. Host header allowlist — on loopback, only localhost, 127.0.0.1, [::1], host.docker.internal (plus port) are accepted; defense against DNS rebinding.
  4. Origin control — by default, any request carrying an Origin header is rejected with 403. When --allow-origin <pattern> is configured, the daemon switches to CORS allowlist mode (allowOriginCors) and only permits matching origins.
  5. Per-route mutation gate — Wave 4 mutating routes can opt in to 401 responses even on loopback when no token is configured, using a distinct code: 'token_required' error.
  6. Device-flow auth — separate OAuth surface for providers (POST /workspace/auth/device-flow + GET/DELETE on /:id).

This doc walks through each layer and the explicit invariants the boot path enforces.

Responsibilities

  • Refuse to boot in unsafe configurations.
  • Gate every HTTP request through bearer (when configured) + host (loopback) + origin checks.
  • Provide a per-route mutation gate Wave 4 routes opt into.
  • Host the device-flow registry that drives provider OAuth flows visible via SSE events.

Architecture

Boot-time refuse rules

In runQwenServe.ts:

ts
if (!isLoopbackBind(opts.hostname) && !token) {
  throw new Error('Refusing to bind <host>:<port> without a bearer token. ...');
}
if (opts.requireAuth && !token) {
  throw new Error(
    'Refusing to start with --require-auth set but no bearer token configured. ...',
  );
}

The allow-origin wildcard has its own refuse rule:

ts
const parsed = parseAllowOriginPatterns(opts.allowOrigins);
if (parsed.allowAny && !token) {
  throw new Error(
    "Refusing to start with --allow-origin '*' but no bearer token configured. ...",
  );
}

All three refusals are explicit boot failures (visible in stderr / thrown to the embedder), never silent. The threat model from #3803 explicitly forbids silently letting a daemon bind beyond loopback in the open.

Middleware chain (HTTP request order)

mermaid
flowchart LR
    REQ[Request] --> SO["strip same-origin Origin
(demo page support)"]
    SO --> CORS{"--allow-origin?"}
    CORS -->|yes| AO["allowOriginCors
(allowlist match)"]
    CORS -->|no| DC["denyBrowserOriginCors
(reject all Origin)"]
    AO --> HA["hostAllowlist"]
    DC --> HA
    HA --> LOG["access-log middleware
(DaemonLogger)"]
    LOG --> BA["bearerAuth"]
    BA --> RL["rate-limit middleware
(when enabled)"]
    RL --> JSON["express.json
(body parser)"]
    JSON --> TEL["daemonTelemetryMiddleware
(OTel span)"]
    TEL --> MG["per-route: mutationGate
(opt-in strict)"]
    MG --> HANDLER["route handler"]

mutationGate is a per-route middleware factory (createMutationGate returns mutate()); routes call mutate() or mutate({strict: true}) at registration time. It is not a global app.use() middleware. Access logging is registered before bearerAuth so 401 rejects are still logged. Rate limiting runs after bearerAuth and before express.json(), so only authenticated requests count and large bodies are rejected before parsing when a limit is exceeded.

bearerAuth

  • No token configured → middleware is a no-op (loopback developer default).
  • Token configured → SHA-256 the configured token once at construction; on every request hash the candidate and timingSafeEqual compare. No string-equality short-circuit; no time-leak.
  • Scheme parsing: case-insensitive Bearer per RFC 7235 §2.1; tolerant of SP\tHTAB between scheme and credentials per RFC 7230 §3.2.6 BWS; rejects pure-HTAB-as-separator.
  • CodeQL hardening: hand-rolled indexOf parsing rather than regex with \s+ / .+ overlap (no polynomial-regex risk).

hostAllowlist

Loopback-only. Maintains a Set<string> keyed by port. Allowed Hosts:

  • localhost:<port>, 127.0.0.1:<port>, [::1]:<port>, host.docker.internal:<port>.
  • Plus no-port forms (localhost, 127.0.0.1, [::1], host.docker.internal) only when bound to port 80 (per RFC 7230 §5.4 default-port omission).

Host comparison is case-insensitive — Express normalizes header names but not values, so Docker proxies that capitalize Hosts (Localhost:4170, HOST.docker.internal) would 403 with an exact-string compare.

Non-loopback binds bypass this middleware (operator chose the surface area; bearer token gates Host spoofing instead).

denyBrowserOriginCors

Reject any request with an Origin header. CLI/SDK never set Origin; only browsers do. Returns deterministic 403 { error: 'Request denied by CORS policy' } rather than the 500 HTML the cors package's error-callback would produce.

Exception: the demo page's same-origin XHRs are handled by a separate middleware (in server.ts) that strips Origin when it matches the daemon's own address.

allowOriginCors (--allow-origin mode)

When --allow-origin <pattern> is configured, denyBrowserOriginCors is replaced with allowOriginCors(parsedPatterns):

  • Matching Origin values receive Access-Control-Allow-Origin, Access-Control-Allow-Headers, and Access-Control-Allow-Methods; OPTIONS preflight returns 204.
  • Non-matching Origin values receive the same deterministic 403 { error: 'Request denied by CORS policy' } as deny mode.
  • --allow-origin '*' requires --token; otherwise boot refuses.
  • parseAllowOriginPatterns() validates pattern syntax at boot.
  • The allow_origin capability tag is advertised only when this mode is configured.

createMutationGate

Per-route opt-in gate. Behavior matrix:

daemon configroute optsresult
requireAuth=trueanypassthrough¹
token configuredanypassthrough²
no token (loopback dev)strict: falsepassthrough
no token (loopback dev)strict: true401 { code: 'token_required' }

¹ --require-auth boots only with a token, so global bearerAuth already 401'd unauthenticated callers. ² Any token configuration makes global bearerAuth enforce bearer-required-everywhere; the gate is redundant but harmless.

The code: 'token_required' shape is distinct from bearerAuth's plain Unauthorized so SDK clients can render a "configure --token / --require-auth" hint instead of a generic 401.

Wave 4+ strict routes: /workspace/memory, /workspace/agents/*, /workspace/agents/generate, /file/write, /file/edit, /workspace/tools/:name/enable, /workspace/mcp/:server/restart, /workspace/mcp/:server/{enable,disable,authenticate,clear-auth}, /workspace/mcp/servers (POST/DELETE), /workspace/auth/device-flow, /workspace/init, /session/:id/approval-mode.

/health exemption

On loopback binds, /health is registered before the bearer middleware so liveness probes inside the pod do not need to carry the token. Non-loopback binds gate /health behind bearer like every other route. --require-auth drops the exemption: /health requires Authorization: Bearer <token> on loopback too.

v1 client identity (X-Qwen-Client-Id) is self-reported

The daemon validates only the format of X-Qwen-Client-Id ([A-Za-z0-9._:-]{1,128}) and tracks attached client ids per session. It does not currently perform proof-of-possession. A client that observes originatorClientId on SSE can re-register the same id and impersonate that originator in later requests.

Impact:

  • designated — a remote caller can impersonate the originator and vote on a request intended only for the prompt originator.
  • consensus — if the spoofed id was already in the votersAtIssue snapshot, it can vote.
  • local-only is not affected because it gates on fromLoopback, which the daemon stamps from the connection remote address.
  • first-responder is not affected because it is identity-agnostic.

A future pair-token mechanism will issue a per-session secret from POST /session; designated / consensus votes will have to present it. Until then, deployments that need a hardened designated policy should bind loopback or run behind an authenticated reverse proxy. See 04-permission-mediation.md for policy-level details.

Device-flow auth

Separate OAuth surface for provider authentication (Qwen OAuth, etc.):

  • POST /workspace/auth/device-flow — start a flow; returns {deviceFlowId, providerId, expiresAt, verificationUrl, userCode}.
  • GET /workspace/auth/device-flow/:id — poll state.
  • DELETE /workspace/auth/device-flow/:id — cancel.
  • GET /workspace/auth/status — current account / provider snapshot.

SSE events auth_device_flow_{started, throttled, authorized, failed, cancelled} fan-out flow state to all subscribers so multi-client UIs stay in sync. See 09-event-schema.md.

Implementation: packages/cli/src/serve/auth/deviceFlow.ts + qwenDeviceFlowProvider.ts.

Log injection / Trojan Source defense: sanitizeForStderr(value) (deviceFlow.ts) replaces ASCII control characters and Unicode control characters with ?. A malicious IdP could otherwise forge log lines or hide payloads:

RangeWhy it is stripped
\x00–\x1f, \x7f, \x80–\x9fASCII C0 / DEL / C1 controls, terminal escapes, and log-line forging.
U+200B-U+200FZero-width characters plus LRM / RLM; invisible but can change terminal rendering.
U+2028-U+2029LINE / PARAGRAPH SEPARATOR; many Unicode-aware terminals treat them as line breaks.
U+202A-U+202EBidirectional EMBEDDING / OVERRIDE controls.
U+2066-U+2069Bidirectional ISOLATE controls (LRI / RLI / FSI / PDI), the main CVE-2021-42574 "Trojan Source" vector. An IdP using U+2066 (LRI) instead of U+202D (LRO) can bypass EMBEDDING/OVERRIDE-only filters with similar visual reordering.
U+FEFFBOM / zero-width no-break space.

Length is preserved by replacing each stripped code point with ? rather than deleting it, so operators can still see that something was present at that index. Both layers use the sanitizer: qwenDeviceFlowProvider sanitizes IdP oauthError, and the registry's late-poll observer sanitizes provider-controlled values interpolated into audit hints (latePollResult.kind / lateErr.name).

The auth_device_flow capability tag is advertised unconditionally; the routes themselves return 400 unsupported_provider if the daemon cannot satisfy a specific provider. The supported-providers list is on /workspace/auth/status rather than /capabilities to keep the descriptor shape uniform.

Workflow

Bearer auth successful request

mermaid
sequenceDiagram
    autonumber
    participant C as Client
    participant BA as bearerAuth
    participant R as Route

    C->>BA: Authorization: Bearer abc...
    BA->>BA: parse scheme (case-insensitive), strip BWS
    BA->>BA: SHA-256(candidate)
    BA->>BA: timingSafeEqual(candidate, expected)
    BA->>R: next()
    R-->>C: 200 ...

Bearer auth failure modes

All return 401 { error: 'Unauthorized' } (uniform across missing header / wrong scheme / wrong token so probing cannot distinguish).

--require-auth shadow

mermaid
sequenceDiagram
    autonumber
    participant C as Unauth client
    participant CAPS as GET /capabilities
    participant BA as bearerAuth

    C->>CAPS: GET /capabilities (no Authorization)
    CAPS->>BA: pass through middleware
    BA-->>C: 401 Unauthorized
    Note over C,BA: client cannot preflight require_auth tag
before authenticating. Discovery surface is the 401 body.

After authenticating, caps.features.includes('require_auth') confirms the deployment is hardened.

Wave 4 mutation gate on no-token loopback

mermaid
sequenceDiagram
    autonumber
    participant C as Client
    participant BA as bearerAuth (no-op, no token)
    participant MG as mutationGate({strict: true})
    participant R as Handler

    C->>BA: POST /workspace/memory (no Authorization)
    BA->>MG: passthrough
    MG-->>C: 401 { code: 'token_required', error: '...' }

State & Lifecycle

  • Bearer token is read at boot and trimmed (newlines from cat token.txt would otherwise silently break comparison).
  • Allowed-Host Set is cached per port; rebuilt on port change (ephemeral 0 → real port post-listen).
  • Mutation gate constructs passthrough and strictDenier once per app build; per-route call returns the cached closure (no per-request allocation).
  • Device-flow registry is disposed on shutdown() Phase 1 so pending flows resolve as cancelled before HTTP teardown.

Dependencies

  • node:cryptocreateHash, timingSafeEqual.
  • packages/cli/src/serve/loopbackBinds.tsisLoopbackBind.
  • packages/cli/src/serve/auth/deviceFlow.ts — device-flow state machine.
  • @qwen-code/acp-bridge — surfaces device-flow events on the per-session SSE bus.

Configuration

SourceKnobEffect
EnvQWEN_SERVER_TOKENBearer token (trimmed).
Flag--tokenBearer token (overrides env).
Flag--require-authExtends bearer to loopback + /health. Boots only with a token.
Flag--hostnameNon-loopback bind requires --token (or env).
Flag--allow-origin <pattern>Switch to CORS allowlist mode. '*' requires a token.
Capability tagsrequire_auth (conditional), auth_device_flow (always), allow_origin (conditional)See 11-capabilities-versioning.md.

Caveats & Known Limits

  • --require-auth shadows feature preflight. Unauthenticated clients cannot discover the require_auth tag; their discovery surface is the 401 body itself.
  • Mutation gate body-parser ordering: mutationGate({strict: true}) 401 responses fire after express.json() parses the body. Worst case on a saturated loopback listener: --max-connections × express.json({limit: '10mb'}) ≈ 2.5 GB transient. Loopback-only attack surface, intentionally accepted.
  • Same-origin Origin stripping in server.ts happens before denyBrowserOriginCors. If a future change moves the strip elsewhere, the demo page breaks.
  • Token comparison is over the SHA-256 digest, not the raw token. Reduces timing leakage by collapsing variable-length token compares to a fixed-size digest compare.
  • The daemon does not carry mTLS, request signing, or pair-token proof-of-possession today. --rate-limit provides HTTP rate limiting by client-id / IP key; it is not client identity authentication.

References

  • packages/cli/src/serve/auth.ts (entire file)
  • packages/cli/src/serve/runQwenServe.ts (refuse rules)
  • packages/cli/src/serve/loopbackBinds.ts
  • packages/cli/src/serve/auth/deviceFlow.ts
  • packages/cli/src/serve/auth/qwenDeviceFlowProvider.ts
  • User-facing threat model: ../../users/qwen-serve.md.
  • Wire reference: ../qwen-serve-protocol.md.