Back to Provenance

Save State Version Mismatch — PR Tracking

docs/save-state-version-mismatch-PR.md

3.3.12.1 KB
Original Source

Save State Version Mismatch — PR Tracking

Branch: agent/save-state-version-mismatch (or per-sub-ticket branches)
Target: develop
Labels: save-states, core-version, high-priority, [Agent]
Copilot Review: Enable via @github/copilot-review or existing AI review workflow


PR Strategy

Prefer small, focused PRs per sub-ticket for easier review. Use this document to track PRs and ensure all launch paths are covered.

PRSub-TicketDescriptionStatus
1#2Centralized SaveStateVersionChecker + alert flowPending
2#1Add createdWithCoreVersion to view models & DTOsPending
3#3Integrate version check into all launch pathsPending
4#4Reset game investigation (PicoDrive / general)Pending
5#6Wiki page + in-app linkPending
6#5Save state porting research (optional)Pending

PR Template Additions

When opening PRs for this epic, include:

What does this PR do

[Link to sub-ticket from docs/save-state-version-mismatch-tickets.md]

Relevant tickets

  • Master: Save State Version Mismatch Detection & UX
  • Sub-ticket: [number and title]

Tags / Labels to Apply

  • save-states
  • core-version
  • high-priority (for master/launch-path PRs)
  • agent-work (if from agent)
  • [Agent] in PR title for AI review trigger

Copilot / AI Review

  • PRs from agent/** branches with [Agent] in title trigger ai-review.yml (see .github/workflows/ai-review-trigger.yml)
  • Ensure @github/copilot-review or equivalent is enabled for the repo if using Copilot for PR review
  • Reviewers: Check that version check is non-blocking (user can "Load Anyway") and that all launch paths are covered

Checklist Before Merge

  • All affected launch paths have version check or are documented as out of scope
  • User can load save state after acknowledging version mismatch
  • No regression: save states with matching version load without extra prompt
  • SwiftLint passes on changed files
  • Manual test on iOS and tvOS (or documented as Mac-only validation needed)