docs/plans/2026-06-15-task-issue-review-gate.md
Objective: Harden task issue intake; done when task rule and template require pre-solution issue challenge gates and sync/verification pass.
Goal plan: docs/plans/2026-06-15-task-issue-review-gate.md
Template: docs/plans/templates/task.md
Primary template: docs/plans/templates/task.md
Applied packs:
Task source:
docs/plans/templates/task.md so public issues are reproduced and reviewed before implementation; hard stop when not reproduced, invalid, or won't-fix; pivot partially valid issues to the best long-term fix; keep final autoreview gate.Completion threshold:
.agents/rules/task.mdc, generated .agents/skills/task/SKILL.md, and
docs/plans/templates/task.md contain a clear pre-solution issue challenge
gate with hard-stop and partial-validity pivot rules.pnpm install syncs generated skills after the rule edit.node .agents/skills/autogoal/scripts/check-complete.mjs docs/plans/2026-06-15-task-issue-review-gate.md passes.Verification surface:
rg across task rule, generated task skill, and task
template.pnpm install, pnpm lint:fix, agent-native review, local autoreview, and
node .agents/skills/autogoal/scripts/check-complete.mjs docs/plans/2026-06-15-task-issue-review-gate.md.Constraints:
Boundaries:
.agents/AGENTS.md rule that
.agents/rules/*.mdc owns generated skill mirrors..agents/rules/task.mdc, generated
.agents/skills/task/SKILL.md via pnpm install,
docs/plans/templates/task.md, and this active plan.Output budget strategy:
sed/rg reads with explicit output caps; avoid broad repo
scans and generated output dumps.Blocked condition:
Task state:
Current verdict:
Pre-solution issue challenge:
pnpm install.Completion rule:
update_goal(status: complete) while any required checklist item
remains unchecked. If an item does not apply, check it and add N/A: <reason>.update_goal(status: complete) until every completion threshold
above is satisfied, final handoff evidence is recorded, and
node .agents/skills/autogoal/scripts/check-complete.mjs docs/plans/2026-06-15-task-issue-review-gate.md passes.Start Gates:
| Gate | Applies | Evidence |
|---|---|---|
| Skill analysis before edits | yes | Loaded task, autoreview, autogoal, and agent-native-reviewer; use pre-solution challenge gate plus final diff review. |
| Active goal checked or created | yes | get_goal returned none; create_goal created this objective. |
| Source of truth read before edits | yes | User request, .agents/rules/task.mdc, docs/plans/templates/task.md, and relevant skill docs read. |
| Tracker comments and attachments read | N/A: no tracker item | User request is the source. |
| Video transcript evidence required | N/A: no video | No tracker video evidence. |
docs/solutions checked for non-trivial existing-code work | N/A: workflow rule/template edit | No product implementation domain. |
| TDD decision before behavior change or bug fix | N/A: no runtime behavior bug | Source audit/review is the honest proof. |
| Branch decision for code-changing task | N/A: user did not ask for commit/PR | Edit current checkout only. |
| Release artifact decision | N/A: no package/runtime release | No changeset or registry changelog. |
| Browser tool decision for browser surface | N/A: no browser surface | Agent workflow text only. |
| PR expectation decision | no | User asked for update/proposal, not PR. |
| Tracker sync expectation decision | N/A: no tracker | No issue/Linear sync. |
| Output budget strategy recorded | yes | Focused reads/searches with caps. |
| Agent-native pack selected | yes | Task changes .agents/** workflow rules. |
| Agent-facing action surface identified | yes | Agents read .agents/skills/task/SKILL.md; source is .agents/rules/task.mdc. |
| Source rule versus generated mirror boundary identified | yes | Edit .agents/rules/task.mdc, regenerate skill mirror with pnpm install. |
agent-native-reviewer loaded or waiver recorded | yes | .agents/skills/agent-native-reviewer/SKILL.md read. |
Work Checklist:
<video-transcripts> XML, or marked N/A with reason..agents/**, .claude/**,
.codex/**, skills, hooks, commands, prompts, or user-action tooling..agents/rules/** changed, or N/A reason is recorded.Completion Gates:
| Gate | Applies | Required action | Evidence |
|---|---|---|---|
| Named verification threshold | yes | Run the command, proof, source audit, or artifact check named in this plan | pnpm install, pnpm lint:fix, source audits, agent-native source audit, and final autoreview passed. |
| Bug reproduced before fix | N/A: workflow repair, not product bug | Record failing test/repro or N/A with reason | Pre-solution issue challenge records reproduction N/A and explains why. |
| Targeted behavior verification | yes | Run focused test/proof for changed behavior or record N/A | Source audit proves rule/template/generated skill contain the new gate and non-bug N/A path. |
| TypeScript or typed config changed | N/A: markdown/rule text only | Run relevant typecheck | No TS or typed config files changed. |
| Package exports or file layout changed | N/A: no package exports/file layout | Run pnpm brl before final verification and keep generated barrel updates | No barrel or export surface changed. |
| Package manifests, lockfile, or install graph changed | N/A: no package manifest or lockfile edit | Run pnpm install and relevant package checks | pnpm install still ran for skill sync; lockfile was up to date. |
| Agent rules or skills changed | yes | Run pnpm install and verify generated skill sync | pnpm install ran after rule edits and skiller applied Codex rules successfully. |
| Workspace authority proof | yes | Run verification in the owning repo/package/app/route/tool and record cwd; do not count the wrong workspace as proof | All commands ran in /Users/zbeyens/git/plate, the repo that owns .agents and task templates. |
| Browser surface changed | N/A: no browser surface | Capture Browser Use proof or record explicit waiver/blocker | Agent workflow text only. |
| Browser final proof | N/A: no browser surface | Attach screenshot or exact browser verification caveat when browser proof applies | No UI/browser route changed. |
| CI-controlled template output changed | N/A: no CI-controlled template output | Restore generated template output or record why it is intentionally kept | docs/plans/templates/task.md is source template, not generated registry/template output. |
| Package behavior or public API changed | N/A: no package behavior/API | Add a changeset or record why no changeset applies | No package changeset needed. |
| Registry-only component work changed | N/A: no registry component work | Update tooling/data/plate-ui-changelog.mdx, run node tooling/scripts/generate-ui-changelog-entries.mjs --write, or record N/A | No registry files changed. |
| Docs or content changed | yes | For docs-heavy work, use --template docs; for incidental docs, verify source-backed claims, links, examples, and rendered output or record N/A | Workflow template/docs text changed; source-backed by rule/template audit. |
| High-risk mini gate | yes | For public API/runtime/package-boundary/browser/agent-action/command-contract changes, record realistic failure mode, proof plan, and why the chosen boundary is right; otherwise N/A | Failure mode: overbroad gate blocks legitimate feature/docs issues; fixed after autoreview by narrowing trigger and adding non-bug N/A path. |
| Agent-native review for agent/tooling changes | yes | For .agents/**, .claude/**, .codex/**, skills, hooks, commands, prompts, or user-action tooling, load .agents/skills/agent-native-reviewer/SKILL.md and close accepted/actionable findings, or record N/A | Agent-native source audit: generated .agents/skills/task/SKILL.md points to .agents/rules/task.mdc and exposes the new action. No remaining findings. |
| Local install corruption suspected | N/A: no suspicious failure | Run pnpm run reinstall once, rerun the exact failing command, or record N/A | Verification failures were review findings, not install corruption. |
| Autoreview for non-trivial implementation changes | yes | Load .agents/skills/autoreview/SKILL.md; use dirty local --mode local, branch/PR --mode branch --base <base>, or committed slice --mode commit --commit <ref> until no accepted/actionable findings, or record N/A for docs-only/trivial/no local patch | .agents/skills/autoreview/scripts/autoreview --mode local first found one accepted P2, then passed clean after fix. |
| PR create or update | N/A: no PR requested and no tracker source | Run check before PR work and sync PR body to the task-style final handoff | User asked for local workflow update/proposal, not PR. |
| Task-style PR body verified | N/A: no PR | Verify the PR body with gh pr view --json body; it must preserve auto-release blocks when applicable, must not include a current-PR self-link, and must use the kitcn PR #270 emoji format: ๐ Fixes ..., ๐ข 95-100% confidence, Phase / ๐งช Tests / ๐ Browser table, and bold emoji Outcome/Caveat/Design/Verified sections | No PR body exists. |
| PR proof image hosting | N/A: no PR/browser proof | If PR body needs browser proof, replace local image paths with hosted GitHub URLs or record N/A | No images needed. |
| Tracker sync-back | N/A: no tracker source | Post concise issue/Linear sync after PR exists, or record N/A/blocker | No issue/Linear item. |
| Final handoff contract | yes | Fill the final handoff fields below with exact PR/issue/confidence/tests/browser/outcome/caveats/design/verification content or N/A reason | Final handoff fields filled below. |
| Final lint | yes | Run pnpm lint:fix or scoped equivalent | pnpm lint:fix passed; no fixes applied. |
| Output budget discipline | yes | Verify no unbounded high-volume command output was streamed, or record the accidental output and recovery | Used scoped sed/rg reads and command output caps. |
| Goal plan complete | yes | Run node .agents/skills/autogoal/scripts/check-complete.mjs docs/plans/2026-06-15-task-issue-review-gate.md | Passed after closeout row fix. |
| Agent source / generated sync | yes | Run pnpm install when .agents/rules/** changed and verify generated mirrors | pnpm install ran twice after source edits; generated task skill includes matching gate text. |
| Agent action discoverability | yes | Source-audit the skill/rule path an agent will read | rg found Public Issue Challenge Gate in .agents/rules/task.mdc and .agents/skills/task/SKILL.md. |
| Agent-native review | yes | Load .agents/skills/agent-native-reviewer/SKILL.md and close accepted findings, or record N/A | Source audit found no agent-native parity gap; agents read the generated skill with source metadata. |
Phase / pass table:
| Phase | Status | Evidence | Next |
|---|---|---|---|
| Intake and source read | complete | source rule, template, and skill docs read | implementation |
| Implementation | complete | task rule/template patched; generated skill synced | verification |
| Verification | complete | lint, source audits, agent-native source audit, and clean autoreview | closeout |
| PR / tracker sync | N/A: user did not ask for PR and no tracker applies | no PR/tracker owner | final response |
| Closeout | complete | mechanical checker caught open closeout row; fixed before final rerun | final response |
Findings:
Public Issue Challenge Gate; task template now has start/checklist/completion rows for the verdict.Decisions and tradeoffs:
.agents/skills/task/SKILL.md directly would drift because .agents/rules
is the source.Implementation notes:
.agents/rules/task.mdc and docs/plans/templates/task.md.pnpm install to regenerate .agents/skills/task/SKILL.md.Review fixes:
N/A path.Error attempts:
| Error / failed attempt | Count | Next different move | Resolution |
|---|---|---|---|
| Initial autoreview found overbroad public issue trigger | 1 | Narrow trigger and add non-bug reproduction N/A path | Fixed; second autoreview passed clean. |
| First goal checker run found Closeout still in progress | 1 | Mark closeout complete after evidence was recorded | Fixed; reran checker. |
Verification evidence:
pnpm install in /Users/zbeyens/git/plate: passed; skiller applied Codex
rules and regenerated .agents/skills/task/SKILL.md.rg -n "Public Issue Challenge Gate|feature, docs, support|non-bug|not reproduced"
across .agents/rules/task.mdc, .agents/skills/task/SKILL.md, and
docs/plans/templates/task.md: passed; source, generated mirror, and template
expose the gate and non-bug N/A path.pnpm lint:fix in /Users/zbeyens/git/plate: passed; no fixes applied..agents/rules/task.mdc..agents/skills/autoreview/scripts/autoreview --mode local: first run found
one accepted P2, fixed; second run clean with no accepted/actionable findings.node .agents/skills/autogoal/scripts/check-complete.mjs docs/plans/2026-06-15-task-issue-review-gate.md:
passed after closeout row fix.Final handoff contract:
.agents/rules/task.mdc plus docs/plans/templates/task.md,
with generated .agents/skills/task/SKILL.md synced by pnpm install.autogoal lifecycle is fine; this is task-specific
public issue intake behavior.pnpm install, pnpm lint:fix, source audit, agent-native source
audit, and clean autoreview.Task-style PR body contract:
<!-- auto-release:start --> block. If a changeset is
part of the diff and repo policy expects auto release, include that block.๐ Fixes #123 or ๐ Fixes โ N/A, then
an emoji confidence line like ๐ข 95-100% confidence.| Phase | ๐งช Tests | ๐ Browser |.Reproduced and Verified rows. Mark passing proof with ๐ข, repro or
failing proof with ๐ด, and non-applicable cells with โ N/A.**โ
Outcome**, **โ ๏ธ Caveat**,
**๐๏ธ Design**, and **๐งช Verified**.Summary / Verification PR body, an
adaptive prose body from a git helper skill, plain ## Outcome sections, or
an unrelated generated badge footer unless the caller or repo template
explicitly asks for it.gh pr view --json body output or a concise source-backed summary
of that output.Final handoff / sync:
Timeline:
pnpm install to sync generated task skill.pnpm lint:fix; passed.Reboot status:
| Question | Answer |
|---|---|
| Where am I? | Closeout |
| Where am I going? | Goal check, update goal complete, final response |
| What is the goal? | Harden task issue intake with a pre-solution challenge gate |
| What have I learned? | Pre-code helper autoreview would be theater; the correct gate is issue validity and durable-boundary review |
| What have I done? | Updated task rule/template, regenerated skill, fixed autoreview finding, verified |
Open risks: