.agents/skills/ce-review/references/persona-catalog.md
16 reviewer personas organized into always-on, cross-cutting conditional, and stack-specific conditional layers, plus CE-specific agents. The orchestrator uses this catalog to select which reviewers to spawn for each review.
Spawned on every review regardless of diff content.
Persona agents (structured JSON output):
| Persona | Agent | Focus |
|---|---|---|
correctness | compound-engineering:review:correctness-reviewer | Logic errors, edge cases, state bugs, error propagation, intent compliance |
testing | compound-engineering:review:testing-reviewer | Coverage gaps, weak assertions, brittle tests, missing edge case tests |
maintainability | compound-engineering:review:maintainability-reviewer | Coupling, complexity, naming, dead code, premature abstraction |
project-standards | compound-engineering:review:project-standards-reviewer | CLAUDE.md and AGENTS.md compliance -- frontmatter, references, naming, cross-platform portability, tool selection |
CE agents (unstructured output, synthesized separately):
| Agent | Focus |
|---|---|
compound-engineering:review:agent-native-reviewer | Verify new features are agent-accessible |
compound-engineering:research:learnings-researcher | Search docs/solutions/ for past issues related to this PR's modules and patterns |
Spawned when the orchestrator identifies relevant patterns in the diff. The orchestrator reads the full diff and reasons about selection -- this is agent judgment, not keyword matching.
| Persona | Agent | Select when diff touches... |
|---|---|---|
security | compound-engineering:review:security-reviewer | Auth middleware, public endpoints, user input handling, permission checks, secrets management |
performance | compound-engineering:review:performance-reviewer | Database queries, ORM calls, loop-heavy data transforms, caching layers, async/concurrent code |
api-contract | compound-engineering:review:api-contract-reviewer | Route definitions, serializer/interface changes, event schemas, exported type signatures, API versioning |
data-migrations | compound-engineering:review:data-migrations-reviewer | Migration files, schema changes, backfill scripts, data transformations |
reliability | compound-engineering:review:reliability-reviewer | Error handling, retry logic, circuit breakers, timeouts, background jobs, async handlers, health checks |
adversarial | compound-engineering:review:adversarial-reviewer | Diff has >=50 changed non-test, non-generated, non-lockfile lines, OR touches auth, payments, data mutations, external API integrations, or other high-risk domains |
previous-comments | compound-engineering:review:previous-comments-reviewer | Reviewing a PR that has existing review comments or review threads from prior review rounds |
These reviewers keep their original opinionated lens. They are additive with the cross-cutting personas above, not replacements for them.
| Persona | Agent | Select when diff touches... |
|---|---|---|
dhh-rails | compound-engineering:review:dhh-rails-reviewer | Rails architecture, service objects, authentication/session choices, Hotwire-vs-SPA boundaries, or abstractions that may fight Rails conventions |
kieran-rails | compound-engineering:review:kieran-rails-reviewer | Rails controllers, models, views, jobs, components, routes, or other application-layer Ruby code where clarity and conventions matter |
kieran-python | compound-engineering:review:kieran-python-reviewer | Python modules, endpoints, services, scripts, or typed domain code |
kieran-typescript | compound-engineering:review:kieran-typescript-reviewer | TypeScript components, services, hooks, utilities, or shared types |
julik-frontend-races | compound-engineering:review:julik-frontend-races-reviewer | Stimulus/Turbo controllers, DOM event wiring, timers, async UI flows, animations, or frontend state transitions with race potential |
These CE-native agents provide specialized analysis beyond what the persona agents cover. Spawn them when the diff includes database migrations, schema.rb, or data backfills.
| Agent | Focus |
|---|---|
compound-engineering:review:schema-drift-detector | Cross-references schema.rb changes against included migrations to catch unrelated drift |
compound-engineering:review:deployment-verification-agent | Produces Go/No-Go deployment checklist with SQL verification queries and rollback procedures |
db/migrate/*.rb, db/schema.rb) or data backfill scripts.