smaller.invalid - Phpstan

Code example

php

<?php declare(strict_types = 1);

function doFoo(\stdClass $object, int $number): void
{
	if ($object < $number) {
		// ...
	}
}

Why is it reported?

The < (less than) comparison is used between types that cannot be meaningfully compared, resulting in a TypeError at runtime. Since PHP 8.0, comparing incompatible types with relational operators (<, >, <=, >=) throws a TypeError. In this example, comparing a \stdClass object with an int is not a valid operation.

How to fix it

Compare values of compatible types. Extract a comparable value from the object first:

diff-php

 <?php declare(strict_types = 1);

 function doFoo(\stdClass $object, int $number): void
 {
-	if ($object < $number) {
+	if ($object->value < $number) {
 		// ...
 	}
 }

Or ensure both operands have comparable types:

diff-php

 <?php declare(strict_types = 1);

-function doFoo(\stdClass $object, int $number): void
+function doFoo(int $a, int $number): void
 {
-	if ($object < $number) {
+	if ($a < $number) {
 		// ...
 	}
 }