website/errors/greater.alwaysTrue.md
<?php declare(strict_types = 1);
/** @param positive-int $i */
function doFoo(int $i): void
{
if ($i > 0) {
echo 'always positive';
}
}
The > comparison always evaluates to true based on the types of the operands. In this example, $i is a positive-int (always >= 1), so $i > 0 is always true.
This usually indicates redundant logic or a mistake in the comparison values. The condition adds no meaningful check and can be simplified.
Remove the redundant condition if it is not needed:
<?php declare(strict_types = 1);
/** @param positive-int $i */
function doFoo(int $i): void
{
- if ($i > 0) {
- echo 'always positive';
- }
+ echo 'always positive';
}
Or fix the comparison to check the intended value:
<?php declare(strict_types = 1);
/** @param positive-int $i */
function doFoo(int $i): void
{
- if ($i > 0) {
+ if ($i > 10) {
echo 'large positive';
}
}