booleanOr.rightNotBoolean

Code example

<?php declare(strict_types = 1);

$bool = false;
$count = 5;

if ($bool || $count) {
	// ...
}

Why is it reported?

The right side of the || (boolean OR) expression is not a boolean value. PHP will implicitly cast the non-boolean value to bool before evaluating the expression. This implicit type coercion can lead to unexpected behaviour depending on PHP's type juggling rules.

This rule is part of phpstan-strict-rules and enforces that only boolean values are used with the || operator, making the code's intent explicit.

In the example above, $count is of type int, not bool, so using it on the right side of || relies on PHP's loose type coercion.

How to fix it

Use an explicit comparison to produce a boolean value:

 <?php declare(strict_types = 1);

 $bool = false;
 $count = 5;

-if ($bool || $count) {
+if ($bool || $count > 0) {
 	// ...
 }

Or convert the value to boolean before using it:

 <?php declare(strict_types = 1);

 $bool = false;
 $count = 5;

-if ($bool || $count) {
+if ($bool || $count !== 0) {
 	// ...
 }