Incremental Test Review: {{PR_TITLE}}

PR Number: {{PR_NUMBER}} Changed Test Files: {{FILE_COUNT}} files Review Date: {{DATE}} Review Mode: Incremental Review

---

Change Summary

Files Modified

{{#EACH FILE}}

• {{FILE_PATH}} (+{{ADDITIONS}} / -{{DELETIONS}}) [{{CLASSIFICATION}}] {{/EACH}}

Classification

• Smoke tests: {{SMOKE_COUNT}} files
• Integration tests: {{INTEGRATION_COUNT}} files
• Filtered out (connector-specific): {{FILTERED_COUNT}} files

---

Review Findings

Critical Issues

<!-- BLOCKER: Must fix before merge -->

{{#IF NO_CRITICAL}} No critical issues found. {{/IF}}

{{#EACH CRITICAL_ISSUE}} {{INDEX}}. {{TITLE}}

• Location: {{FILE}}:{{LINE}}
• Standard: standards/smoke-and-integration.md - {{SECTION}}
• Issue: {{DESCRIPTION}}
• Fix: {{RECOMMENDATION}} {{/EACH}}

Warnings

<!-- WARNING: Should address -->

{{#EACH WARNING}}

• {{FILE}}:{{LINE}} - {{DESCRIPTION}} {{/EACH}}

Suggestions

<!-- SUGGESTION: Optional improvements -->

{{#EACH SUGGESTION}}

• {{DESCRIPTION}} {{/EACH}}

---

Test-Specific Checklist

For New Smoke Tests

• [{{NEW_LIFECYCLE}}] Uses _ingest_cleanup_data_impl data lifecycle pattern
• [{{NEW_AUTH}}] Uses auth_session fixture (not inline credentials)
• [{{NEW_RETRY}}] Uses retry patterns (no bare time.sleep)
• [{{NEW_CLEANUP}}] Cleanup in fixture teardown
• [{{NEW_NAMES}}] Descriptive test names
• [{{NEW_ASSERTIONS}}] Non-trivial assertions

For New Cypress Integration Tests

• [{{NEW_ISOLATION}}] Uses unique random IDs per describe block
• [{{NEW_SELECTORS}}] Uses data-testid selectors (not CSS classes)
• [{{NEW_LOGIN}}] Calls cy.login() per test or in beforeEach
• [{{NEW_CY_ASSERT}}] Has non-trivial assertions (cy.waitTextVisible, .should())

For Modified Tests

• [{{MOD_EXISTING}}] Existing test behavior preserved
• [{{MOD_GOLDEN}}] Golden files updated if output changed
• [{{MOD_NO_REGRESSION}}] No new anti-patterns introduced

---

Verdict

{{VERDICT}}

<!-- Options: APPROVED / NEEDS CHANGES / BLOCKED -->

Required Changes

{{#EACH REQUIRED_CHANGE}} {{INDEX}}. {{DESCRIPTION}} {{/EACH}}

Optional Improvements

{{#EACH OPTIONAL_IMPROVEMENT}}

• {{DESCRIPTION}} {{/EACH}}

---

Review generated by DataHub Test Review Skill