forgejo-contrib-forgejo-cli-pulls-535.md
Watch20
Star402
Fork
You've already forked forgejo-cli
CodeIssues 44Pull requests 8Releases 11Packages 2WikiActivity
Merged
Cyborusmerged 1 commit from Fluffinity/forgejo-cli:fix-oauth-crash into main 2026-07-06 20:05:57 +02:00
Conversation 1Commits 1Files changed 2 +5 -3
Fluffinity commented 2026-06-28 10:43:29 +02:00
Contributor
Copy link
Currently unwrap is called on the result of open::that_detached, causing a crash in the case of any underlying errors.
One such crash has been reported due to a missing file or directory. We now create an eyre report instead in such cases,
handling the error gracefully.
Handles one use of unwrap, discussed in #534
unwrap is called on the result of open::that_detached, causing a crash in the case of any underlying errors. One such crash has been reported due to a missing file or directory. We now create an eyre report instead in such cases, handling the error gracefully. Handles one use of unwrap, discussed in #534 ### Code of Conduct - [x] I agree to act in accordance with the CoC & AI Agreement. - [x] This contribution was not generated by an LLM, even in part.Fluffinity added 1 commit 2026-06-28 10:43:31 +02:00
fix(auth): handle oauth open error gracefully...
All checks were successful
ci/woodpecker/pr/check-typos Pipeline was successful
ci/woodpecker/pr/check Pipeline was successful
ci/woodpecker/pr/check-clippy Pipeline was successful
We just `unwrap` the result of `open::that_detached`, which just crashed
the CLI if unsuccessful. We want to give the user a better error message
instead, so we now create an eyre Report for that error.
Fluffinity force-pushed fix-oauth-crash from 1f390bc24c
All checks were successful
ci/woodpecker/pr/check-typos Pipeline was successful
ci/woodpecker/pr/check Pipeline was successful
ci/woodpecker/pr/check-clippy Pipeline was successful
to 29e1ee3341
All checks were successful
ci/woodpecker/pr/check-typos Pipeline was successful
ci/woodpecker/pr/check Pipeline was successful
ci/woodpecker/pr/check-clippy Pipeline was successful
2026-06-28 11:32:23 +02:00 Compare
Fluffinity force-pushed fix-oauth-crash from 29e1ee3341
All checks were successful
ci/woodpecker/pr/check-typos Pipeline was successful
ci/woodpecker/pr/check Pipeline was successful
ci/woodpecker/pr/check-clippy Pipeline was successful
to f6a9d38ef2
All checks were successful
ci/woodpecker/pr/check-typos Pipeline was successful
ci/woodpecker/pr/check-clippy Pipeline was successful
ci/woodpecker/pr/check Pipeline was successful
2026-06-28 14:03:58 +02:00 Compare
Fluffinity force-pushed fix-oauth-crash from f6a9d38ef2
All checks were successful
ci/woodpecker/pr/check-typos Pipeline was successful
ci/woodpecker/pr/check-clippy Pipeline was successful
ci/woodpecker/pr/check Pipeline was successful
to 49721f3068
All checks were successful
ci/woodpecker/pr/check-typos Pipeline was successful
ci/woodpecker/pr/check Pipeline was successful
ci/woodpecker/pr/check-clippy Pipeline was successful
2026-06-29 13:55:01 +02:00 Compare
Fluffinity commented 2026-06-29 13:55:05 +02:00
Author
Contributor
Copy link
Rebased onto current main
Rebased onto current main
Cyborus approved these changes 2026-06-29 20:24:16 +02:00 Dismissed
Cyborus left a comment
Copy link
Minor thing: oauth should be OAuth. Otherwise looks great!
Minor thing: oauth should be OAuth. Otherwise looks great!
👍 1
Fluffinity force-pushed fix-oauth-crash from 49721f3068
All checks were successful
ci/woodpecker/pr/check-typos Pipeline was successful
ci/woodpecker/pr/check Pipeline was successful
ci/woodpecker/pr/check-clippy Pipeline was successful
to 37666a39a3
All checks were successful
ci/woodpecker/pr/check-typos Pipeline was successful
ci/woodpecker/pr/check Pipeline was successful
ci/woodpecker/pr/check-clippy Pipeline was successful
2026-06-29 20:42:15 +02:00 Compare
Fluffinity dismissed Cyborus's review 2026-06-29 20:42:16 +02:00
New commits pushed, approval review dismissed automatically according to repository settings
Cyborus approved these changes 2026-06-29 20:42:51 +02:00 Dismissed
Cyborus approved these changes 2026-07-06 20:05:49 +02:00
Cyborus merged commit 02b68f94a9 into main 2026-07-06 20:05:57 +02:00
Cyborus referenced this pull request from a commit 2026-07-06 20:05:58 +02:00 Merge pull request 'fix(auth): handle detached opening error gracefully' (#535) from Fluffinity/forgejo-cli:fix-oauth-crash into main
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels[ Kind/Breaking Breaking change that won't be backward compatible
](#)[ Kind/Bug Something is not working
](#)[ Kind/Design Discussion about UI/UX design
](#)[ Kind/Documentation Documentation changes
](#)[ Kind/Enhancement Improve existing functionality
](#)[ Kind/Feature New functionality
](#)[ Kind/Security This is security issue
](#)[ Kind/Testing Issue or pull request related to testing
](#)[ Kind/Upstream This is an issue with upstream software (Forgejo) that is probably not our fault
](#)
[ Priority
Critical The priority is critical
](#)[ Priority
High The priority is high
](#)[ Priority
Low The priority is low
](#)[ Priority
Medium The priority is medium
](#)
[ Reviewed
Confirmed Issue has been confirmed
](#)[ Reviewed
Duplicate This issue or pull request already exists
](#)[ Reviewed
Invalid Invalid issue
](#)[ Reviewed
Won't Fix This issue won't be fixed
](#)
[ Status
Abandoned Somebody has started to work on this but abandoned work
](#)[ Status
Blocked Something is blocking this issue or pull request
](#)[ Status
Need More Info Feedback is required to reproduce issue or to continue work
](#)
[ Suspicious
](#)
No labels Kind/Breaking Kind/Bug Kind/Design Kind/Documentation Kind/Enhancement Kind/Feature Kind/Security Kind/Testing Kind/Upstream [ Priority
Critical ](/forgejo-contrib/forgejo-cli/pulls?labels=173012) [ Priority
High ](/forgejo-contrib/forgejo-cli/pulls?labels=173013) [ Priority
Low ](/forgejo-contrib/forgejo-cli/pulls?labels=173015) [ Priority
Medium ](/forgejo-contrib/forgejo-cli/pulls?labels=173014) [ Reviewed
Confirmed ](/forgejo-contrib/forgejo-cli/pulls?labels=173007) [ Reviewed
Duplicate ](/forgejo-contrib/forgejo-cli/pulls?labels=173005) [ Reviewed
Invalid ](/forgejo-contrib/forgejo-cli/pulls?labels=173006) [ Reviewed
Won't Fix ](/forgejo-contrib/forgejo-cli/pulls?labels=173008) [ Status
Abandoned ](/forgejo-contrib/forgejo-cli/pulls?labels=173011) [ Status
Blocked ](/forgejo-contrib/forgejo-cli/pulls?labels=173010) [ Status
Need More Info ](/forgejo-contrib/forgejo-cli/pulls?labels=173009) Suspicious
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
Notifications Subscribe
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
forgejo-contrib/forgejo-cli!535
WritePreview
Loading…
Add table
| Rows | | | Columns | |
CancelOK
Add a link
Url Description Hint: With a URL in your clipboard, you can paste directly into the editor to create a link.
CancelOK
CancelSave
Reference in a new issue
Repository
forgejo-contrib/forgejo-cli
Title
Body
Create issue
No description provided.
Delete branch "Fluffinity/forgejo-cli:fix-oauth-crash"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
No Yes