forgejo-contrib-forgejo-cli-pulls-523.md
Watch20
Star402
Fork
You've already forked forgejo-cli
CodeIssues 44Pull requests 8Releases 11Packages 2WikiActivity
Merged
Cyborusmerged 1 commit from Fluffinity/forgejo-cli:rename-add-key into main 2026-07-06 22:34:39 +02:00
Conversation 7Commits 1Files changed 10 +31 -31
Fluffinity commented 2026-06-24 15:19:40 +02:00
Contributor
Copy link
The auth add-key subcommand was confusingly named, as users would associate SSH/GPG keys with that command. In order to make it clear, that this command is for adding tokens, it gets renamed to auth add-token. To preserve backwards compatibility, the old subcommand is made an alias of the new name. We need to look at how weblate handles the changed translation keys.
auth add-key subcommand was confusingly named, as users would associate SSH/GPG keys with that command. In order to make it clear, that this command is for adding tokens, it gets renamed to auth add-token. To preserve backwards compatibility, the old subcommand is made an alias of the new name. We need to look at how weblate handles the changed translation keys. ### Code of Conduct - [x] I agree to act in accordance with the CoC & AI Agreement. - [x] This contribution was not generated by an LLM, even in part.Fluffinity added 1 commit 2026-06-24 15:20:01 +02:00
refactor: rename auth add-key subcommand to auth add-token...
All checks were successful
ci/woodpecker/pr/check-clippy Pipeline was successful
ci/woodpecker/pr/check-typos Pipeline was successful
ci/woodpecker/pr/check Pipeline was successful
The current `auth add-key` subcommand is confusingly named, as this
command does not add any SSH/GPG keys. Instead it adds application
tokens to the CLI. With the rename this purpose becomes clearer. For
backwards compatibility the old `auth add-key` syntax has been made an
alias for the new subcommand.
Cyborus approved these changes 2026-06-24 20:49:02 +02:00 Dismissed
Cyborus requested changes 2026-07-06 20:10:27 +02:00 Dismissed
localization/en-US/messages.ftl Outdated
Show resolved Hide resolved
| | | | @ -42,3 +42,1 @@ |
| | | | | help-arg-auth-add_key-key = The key to add. If not present, the key will be read in from stdin |
| | | | | msg-auth-add_key-prompt = new key: |
| | | | | msg-auth-add_key-already_exists = key for {$host} already exists |
| | | | | help-arg-auth-add_token-key = The key to add. If not present, the key will be read in from stdin |
Cyborus commented 2026-07-06 20:09:55 +02:00
Member
Copy link
-help-arg-auth-add_token-key
+help-arg-auth-add_token-token
diff -help-arg-auth-add_token-key +help-arg-auth-add_token-token
Cyborus marked this conversation as resolved
src/auth.rs Outdated
Show resolved Hide resolved
| | | | @ -19,1 +16,3 @@ |
| | | | | key: Option<String>, |
| | | | | #[clap(about = h!("cmd-auth-add_token"), long_about = lh!("cmd-auth-add_token"), alias = "add-key")] |
| | | | | AddToken { |
| | | | | #[clap(help = h!("arg-auth-add_token-key"))] |
Cyborus commented 2026-07-06 20:10:03 +02:00
Member
Copy link
Ditto
Ditto
Cyborus marked this conversation as resolved
Fluffinity force-pushed rename-add-key from 8bf7a2a163
All checks were successful
ci/woodpecker/pr/check-clippy Pipeline was successful
ci/woodpecker/pr/check-typos Pipeline was successful
ci/woodpecker/pr/check Pipeline was successful
to b367981bca
Some checks failed
ci/woodpecker/pr/check-clippy Pipeline failed
ci/woodpecker/pr/check-typos Pipeline failed
ci/woodpecker/pr/check Pipeline failed
2026-07-06 20:13:56 +02:00 Compare
Fluffinity dismissed Cyborus's review 2026-07-06 20:13:56 +02:00
New commits pushed, approval review dismissed automatically according to repository settings
Fluffinity commented 2026-07-06 20:17:19 +02:00
Author
Contributor
Copy link
Renamed the ftl key. Also, the CI needs to be re-run; it failed at cloning the repo
Renamed the ftl key. Also, the CI needs to be re-run; it failed at cloning the repo
Fluffinity force-pushed rename-add-key from b367981bca
Some checks failed
ci/woodpecker/pr/check-clippy Pipeline failed
ci/woodpecker/pr/check-typos Pipeline failed
ci/woodpecker/pr/check Pipeline failed
to 43a61fa7b8
All checks were successful
ci/woodpecker/pr/check-typos Pipeline was successful
ci/woodpecker/pr/check Pipeline was successful
ci/woodpecker/pr/check-clippy Pipeline was successful
2026-07-06 20:18:30 +02:00 Compare
Cyborus commented 2026-07-06 20:19:27 +02:00
Member
Copy link
CI seems to be down right now, rerunning it doesn't help.
CI seems to be down right now, rerunning it doesn't help.
Fluffinity commented 2026-07-06 20:20:43 +02:00
Author
Contributor
Copy link
I guess, we wait then
I guess, we wait then
👍 1
Cyborus approved these changes 2026-07-06 21:18:50 +02:00 Dismissed
Fluffinity force-pushed rename-add-key from 43a61fa7b8
All checks were successful
ci/woodpecker/pr/check-typos Pipeline was successful
ci/woodpecker/pr/check Pipeline was successful
ci/woodpecker/pr/check-clippy Pipeline was successful
to b1d16c6d02
All checks were successful
ci/woodpecker/pr/check-typos Pipeline was successful
ci/woodpecker/pr/check Pipeline was successful
ci/woodpecker/pr/check-clippy Pipeline was successful
2026-07-06 22:30:23 +02:00 Compare
Fluffinity dismissed Cyborus's review 2026-07-06 22:30:23 +02:00
New commits pushed, approval review dismissed automatically according to repository settings
Fluffinity commented 2026-07-06 22:31:13 +02:00
Author
Contributor
Copy link
The conflict in the German translations has been resolved. They just used the old key names
The conflict in the German translations has been resolved. They just used the old key names
👍 1
Cyborus merged commit ce933407b6 into main 2026-07-06 22:34:39 +02:00
Cyborus referenced this pull request from a commit 2026-07-06 22:34:41 +02:00 Merge pull request 'refactor: rename auth add-key to auth add-token' (#523) from Fluffinity/forgejo-cli:rename-add-key into main
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels[ Kind/Breaking Breaking change that won't be backward compatible
](#)[ Kind/Bug Something is not working
](#)[ Kind/Design Discussion about UI/UX design
](#)[ Kind/Documentation Documentation changes
](#)[ Kind/Enhancement Improve existing functionality
](#)[ Kind/Feature New functionality
](#)[ Kind/Security This is security issue
](#)[ Kind/Testing Issue or pull request related to testing
](#)[ Kind/Upstream This is an issue with upstream software (Forgejo) that is probably not our fault
](#)
[ Priority
Critical The priority is critical
](#)[ Priority
High The priority is high
](#)[ Priority
Low The priority is low
](#)[ Priority
Medium The priority is medium
](#)
[ Reviewed
Confirmed Issue has been confirmed
](#)[ Reviewed
Duplicate This issue or pull request already exists
](#)[ Reviewed
Invalid Invalid issue
](#)[ Reviewed
Won't Fix This issue won't be fixed
](#)
[ Status
Abandoned Somebody has started to work on this but abandoned work
](#)[ Status
Blocked Something is blocking this issue or pull request
](#)[ Status
Need More Info Feedback is required to reproduce issue or to continue work
](#)
[ Suspicious
](#)
No labels Kind/Breaking Kind/Bug Kind/Design Kind/Documentation Kind/Enhancement Kind/Feature Kind/Security Kind/Testing Kind/Upstream [ Priority
Critical ](/forgejo-contrib/forgejo-cli/pulls?labels=173012) [ Priority
High ](/forgejo-contrib/forgejo-cli/pulls?labels=173013) [ Priority
Low ](/forgejo-contrib/forgejo-cli/pulls?labels=173015) [ Priority
Medium ](/forgejo-contrib/forgejo-cli/pulls?labels=173014) [ Reviewed
Confirmed ](/forgejo-contrib/forgejo-cli/pulls?labels=173007) [ Reviewed
Duplicate ](/forgejo-contrib/forgejo-cli/pulls?labels=173005) [ Reviewed
Invalid ](/forgejo-contrib/forgejo-cli/pulls?labels=173006) [ Reviewed
Won't Fix ](/forgejo-contrib/forgejo-cli/pulls?labels=173008) [ Status
Abandoned ](/forgejo-contrib/forgejo-cli/pulls?labels=173011) [ Status
Blocked ](/forgejo-contrib/forgejo-cli/pulls?labels=173010) [ Status
Need More Info ](/forgejo-contrib/forgejo-cli/pulls?labels=173009) Suspicious
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
Notifications Subscribe
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
forgejo-contrib/forgejo-cli!523
WritePreview
Loading…
Add table
| Rows | | | Columns | |
CancelOK
Add a link
Url Description Hint: With a URL in your clipboard, you can paste directly into the editor to create a link.
CancelOK
CancelSave
Reference in a new issue
Repository
forgejo-contrib/forgejo-cli
Title
Body
Create issue
No description provided.
Delete branch "Fluffinity/forgejo-cli:rename-add-key"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
No Yes