Back to Codeberg

fix(oauth): detach opened browser #407

forgejo-contrib-forgejo-cli-pulls-407.md

latest8.9 KB
Original Source

forgejo-contrib/forgejo-cli

Watch20

Star402

Fork

You've already forked forgejo-cli

51

CodeIssues 44Pull requests 8Releases 11Packages 2WikiActivity

fix(oauth): detach opened browser #407

Merged

Cyborusmerged 1 commit from cyborus/detach-browser-open into main 2026-04-10 19:26:42 +02:00AGit

Conversation 2Commits 1Files changed 1 +1 -1

Cyborus commented 2026-04-10 18:54:49 +02:00

Member

Copy link

Changes Made

fj auth login was using open::that to open the browser to get verification from the user. open::that tries to not block, but it still sometimes does. open::that_detached ensures it doesn't block, by detaching the spawned process.

Fixes #405

Code of Conduct

  • I agree to act in accordance with the CoC & AI Agreement.
  • This contribution was not generated by an LLM, even in part.

Changes Made fj auth login was using open::that to open the browser to get verification from the user. open::that tries to not block, but it still sometimes does. open::that_detached ensures it doesn't block, by detaching the spawned process. Fixes #405 ### Code of Conduct - [x] I agree to act in accordance with the CoC & AI Agreement. - [x] This contribution was not generated by an LLM, even in part.

Cyborus added 1 commit 2026-04-10 18:54:49 +02:00

fix(oauth): detach opened browser

All checks were successful

ci/woodpecker/pr/check Pipeline was successful

Details

1514dc73bf

Cyborus commented 2026-04-10 18:55:32 +02:00

Author

Member

Copy link

cc @balejk

cc @balejk

balejk commented 2026-04-10 19:11:17 +02:00

First-time contributor

Copy link

Yes, this fixes the issue for me, thanks!

Yes, this fixes the issue for me, thanks!

🎉 1

Cyborus merged commit 3a6de9097c into main 2026-04-10 19:26:42 +02:00

Cyborus referenced this pull request from a commit 2026-04-10 19:26:43 +02:00 Merge pull request 'fix(oauth): detach opened browser' (#407) from cyborus/detach-browser-open into main

Cyborus added this to the v0.5.0 milestone 2026-04-10 19:26:48 +02:00

stalecontext referenced this pull request from stalecontext/forgejo-cli-plus 2026-07-02 21:51:40 +02:00 Upstream sync 2026-07-02 #52

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels[ Kind/Breaking Breaking change that won't be backward compatible

](#)[ Kind/Bug Something is not working

](#)[ Kind/Design Discussion about UI/UX design

](#)[ Kind/Documentation Documentation changes

](#)[ Kind/Enhancement Improve existing functionality

](#)[ Kind/Feature New functionality

](#)[ Kind/Security This is security issue

](#)[ Kind/Testing Issue or pull request related to testing

](#)[ Kind/Upstream This is an issue with upstream software (Forgejo) that is probably not our fault

](#)

[ Priority

Critical The priority is critical

](#)[ Priority

High The priority is high

](#)[ Priority

Low The priority is low

](#)[ Priority

Medium The priority is medium

](#)

[ Reviewed

Confirmed Issue has been confirmed

](#)[ Reviewed

Duplicate This issue or pull request already exists

](#)[ Reviewed

Invalid Invalid issue

](#)[ Reviewed

Won't Fix This issue won't be fixed

](#)

[ Status

Abandoned Somebody has started to work on this but abandoned work

](#)[ Status

Blocked Something is blocking this issue or pull request

](#)[ Status

Need More Info Feedback is required to reproduce issue or to continue work

](#)

[ Suspicious

](#)

No labels Kind/Breaking Kind/Bug Kind/Design Kind/Documentation Kind/Enhancement Kind/Feature Kind/Security Kind/Testing Kind/Upstream [ Priority

Critical ](/forgejo-contrib/forgejo-cli/pulls?labels=173012) [ Priority

High ](/forgejo-contrib/forgejo-cli/pulls?labels=173013) [ Priority

Low ](/forgejo-contrib/forgejo-cli/pulls?labels=173015) [ Priority

Medium ](/forgejo-contrib/forgejo-cli/pulls?labels=173014) [ Reviewed

Confirmed ](/forgejo-contrib/forgejo-cli/pulls?labels=173007) [ Reviewed

Duplicate ](/forgejo-contrib/forgejo-cli/pulls?labels=173005) [ Reviewed

Invalid ](/forgejo-contrib/forgejo-cli/pulls?labels=173006) [ Reviewed

Won't Fix ](/forgejo-contrib/forgejo-cli/pulls?labels=173008) [ Status

Abandoned ](/forgejo-contrib/forgejo-cli/pulls?labels=173011) [ Status

Blocked ](/forgejo-contrib/forgejo-cli/pulls?labels=173010) [ Status

Need More Info ](/forgejo-contrib/forgejo-cli/pulls?labels=173009) Suspicious

Milestone

Clear milestone

No items

No milestone v0.5.0

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

forgejo-contrib/forgejo-cli!407

WritePreview

Loading…

Add table

| Rows | | | Columns | |

CancelOK

Add a link

Url Description Hint: With a URL in your clipboard, you can paste directly into the editor to create a link.

CancelOK

CancelSave

Reference in a new issue

Repository

forgejo-contrib/forgejo-cli

Title

Body

Create issue

No description provided.

Delete branch "cyborus/detach-browser-open"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?

No Yes