forgejo-contrib-forgejo-cli-pulls-349.md
Watch20
Star402
Fork
You've already forked forgejo-cli
CodeIssues 44Pull requests 8Releases 11Packages 2WikiActivity
Merged
Cyborusmerged 2 commits from LordMZTE/forgejo-cli:repo-edit into main 2026-04-09 16:08:35 +02:00
Conversation 3Commits 2Files changed 1 +374
LordMZTE commented 2026-03-10 11:53:16 +01:00
Collaborator
Copy link
This adds subcommands to edit repositories and repo units. The PATCH /repo/{owner}/{repo} endpoint is fully covered except for external_tracker and internal_tracker, which I'm still unsure how to write an interface for (feedback welcome!).
Closes #345
Related: #281 (this implements a means to archive and un-archive repos)
Related: Cyborus/forgejo-api#139
This adds subcommands to edit repositories and repo units. The PATCH /repo/{owner}/{repo} endpoint is fully covered except for external_tracker and internal_tracker, which I'm still unsure how to write an interface for (feedback welcome!). Closes #345 Related: #281 (this implements a means to archive and un-archive repos) Related: Cyborus/forgejo-api#139
❤️ 2
LordMZTE added 1 commit 2026-03-10 11:53:16 +01:00
feat: repo edit command 41a9922e37
LordMZTE requested review from Cyborus 2026-03-11 19:43:44 +01:00
Cyborus requested changes 2026-03-14 20:34:55 +01:00 Dismissed
src/repo.rs Outdated
Show resolved Hide resolved
| | | | @ -676,0 +805,4 @@ |
| | | | | .name() |
| | | | | .ok_or_eyre("couldn't get repo name, please specify")?; |
| | | | | |
| | | | | match cmd { |
Cyborus commented 2026-03-13 21:50:41 +01:00
Member
Copy link
This match could return EditRepoOption, which gets passed into a single .repo_edit invocation immediately afterwards. I doubt this command will ever need to hit any other endpoint.
This match could return EditRepoOption, which gets passed into a single .repo_edit invocation immediately afterwards. I doubt this command will ever need to hit any other endpoint.
LordMZTE marked this conversation as resolved
src/repo.rs Outdated
Show outdated Hide outdated
| | | | @ -744,0 +1008,4 @@ |
| | | | | #[clap(short, long)] |
| | | | | enable: Option<bool>, |
| | | | | // TODO: external_tracker, internal_tracker |
| | | | | // These accept quite sophisticated data structures, not sure how to model those. |
Cyborus commented 2026-03-13 21:52:56 +01:00
Member
Copy link
I'm really not sure either? That's where most of the delay in reviewing has come from, I've been stumped on trying to answer this.
I'm really not sure either? That's where most of the delay in reviewing has come from, I've been stumped on trying to answer this.
src/repo.rs Outdated
Show resolved Hide resolved
| | | | @ -744,0 +1091,4 @@ |
| | | | | /// Set the URL for an external wiki. |
| | | | | /// If no URL is given, the external wiki is instead disabled. |
| | | | | #[clap(long)] |
| | | | | external_wiki: Option<Url>, |
Cyborus commented 2026-03-13 21:54:06 +01:00
Member
Copy link
external_url maybe? Repeating wiki seems redundant.
external_url maybe? Repeating wiki seems redundant.
LordMZTE marked this conversation as resolved
LordMZTE force-pushed repo-edit from 0a32352d9a
All checks were successful
ci/woodpecker/pr/check Pipeline was successful
to 90449f42a2
All checks were successful
ci/woodpecker/pr/check Pipeline was successful
2026-03-15 10:34:12 +01:00 Compare
LordMZTE commented 2026-04-09 10:21:47 +02:00
Author
Collaborator
Copy link
@Cyborus do you have any ideas how we could design the external/internal tracker issue configuration interface? If not, we could also consider merging this PR without that for now, as it's probably an infrequently used feature anyways.
@Cyborus do you have any ideas how we could design the external/internal tracker issue configuration interface? If not, we could also consider merging this PR without that for now, as it's probably an infrequently used feature anyways.
Cyborus commented 2026-04-09 16:06:03 +02:00
Member
Copy link
Still no idea. I'm good with merging as-is
Still no idea. I'm good with merging as-is
Cyborus approved these changes 2026-04-09 16:06:38 +02:00
Cyborus merged commit 834bd303fb into main 2026-04-09 16:08:35 +02:00
Cyborus referenced this pull request from a commit 2026-04-09 16:08:38 +02:00 Merge pull request 'repo edit & repo units commands' (#349) from LordMZTE/forgejo-cli:repo-edit into main
Cyborus referenced this pull request 2026-04-09 16:24:47 +02:00
external issue trackers in fj repo units issues #402
LordMZTE deleted branch repo-edit 2026-04-09 21:58:11 +02:00
Cyborus added this to the v0.5.0 milestone 2026-04-16 20:24:30 +02:00
stalecontext referenced this pull request from stalecontext/forgejo-cli-plus 2026-07-02 21:51:40 +02:00 Upstream sync 2026-07-02 #52
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels[ Kind/Breaking Breaking change that won't be backward compatible
](#)[ Kind/Bug Something is not working
](#)[ Kind/Design Discussion about UI/UX design
](#)[ Kind/Documentation Documentation changes
](#)[ Kind/Enhancement Improve existing functionality
](#)[ Kind/Feature New functionality
](#)[ Kind/Security This is security issue
](#)[ Kind/Testing Issue or pull request related to testing
](#)[ Kind/Upstream This is an issue with upstream software (Forgejo) that is probably not our fault
](#)
[ Priority
Critical The priority is critical
](#)[ Priority
High The priority is high
](#)[ Priority
Low The priority is low
](#)[ Priority
Medium The priority is medium
](#)
[ Reviewed
Confirmed Issue has been confirmed
](#)[ Reviewed
Duplicate This issue or pull request already exists
](#)[ Reviewed
Invalid Invalid issue
](#)[ Reviewed
Won't Fix This issue won't be fixed
](#)
[ Status
Abandoned Somebody has started to work on this but abandoned work
](#)[ Status
Blocked Something is blocking this issue or pull request
](#)[ Status
Need More Info Feedback is required to reproduce issue or to continue work
](#)
[ Suspicious
](#)
No labels Kind/Breaking Kind/Bug Kind/Design Kind/Documentation Kind/Enhancement Kind/Feature Kind/Security Kind/Testing Kind/Upstream [ Priority
Critical ](/forgejo-contrib/forgejo-cli/pulls?labels=173012) [ Priority
High ](/forgejo-contrib/forgejo-cli/pulls?labels=173013) [ Priority
Low ](/forgejo-contrib/forgejo-cli/pulls?labels=173015) [ Priority
Medium ](/forgejo-contrib/forgejo-cli/pulls?labels=173014) [ Reviewed
Confirmed ](/forgejo-contrib/forgejo-cli/pulls?labels=173007) [ Reviewed
Duplicate ](/forgejo-contrib/forgejo-cli/pulls?labels=173005) [ Reviewed
Invalid ](/forgejo-contrib/forgejo-cli/pulls?labels=173006) [ Reviewed
Won't Fix ](/forgejo-contrib/forgejo-cli/pulls?labels=173008) [ Status
Abandoned ](/forgejo-contrib/forgejo-cli/pulls?labels=173011) [ Status
Blocked ](/forgejo-contrib/forgejo-cli/pulls?labels=173010) [ Status
Need More Info ](/forgejo-contrib/forgejo-cli/pulls?labels=173009) Suspicious
Milestone
Clear milestone
No items
No milestone v0.5.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
Notifications Subscribe
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
forgejo-contrib/forgejo-cli!349
WritePreview
Loading…
Add table
| Rows | | | Columns | |
CancelOK
Add a link
Url Description Hint: With a URL in your clipboard, you can paste directly into the editor to create a link.
CancelOK
CancelSave
Reference in a new issue
Repository
forgejo-contrib/forgejo-cli
Title
Body
Create issue
No description provided.
Delete branch "LordMZTE/forgejo-cli:repo-edit"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
No Yes