forgejo-contrib-forgejo-cli-pulls-250.md
Watch20
Star402
Fork
You've already forked forgejo-cli
CodeIssues 44Pull requests 8Releases 11Packages 2WikiActivity
Merged
Cyborusmerged 2 commits from consistent-host-name into main 2025-12-20 16:50:08 +01:00
Conversation 5Commits 2Files changed 7 +40 -43
Cyborus commented 2025-12-18 00:32:12 +01:00
Member
Copy link
This ensures the instance name (such as in the keys file) is the same anywhere it is accessed, and always includes the url's path if it is present, to better support instances that are on a subpath rather than subdomain.
This ensures the instance name (such as in the keys file) is the same anywhere it is accessed, and always includes the url's path if it is present, to better support instances that are on a subpath rather than subdomain.
Cyborus added 2 commits 2025-12-18 00:32:13 +01:00
fix: replace host_with_path[_and_port] with host_name... 5d0366012a
This ensures the instance name (such as in the keys file) is the same
anywhere it is accessed, and always includes the url's path if it is
present, to better support instances that are on a subpath rather than
subdomain.
refactor: replace Url::host_str with {repo_url_}host_name...
All checks were successful
ci/woodpecker/pr/check Pipeline was successful
`Url::host_str` was being used to get the instance name from repository
URLs. This didn't include the path the instance may be on. This change
makes it so it does.
Cyborus commented 2025-12-18 00:34:26 +01:00
Author
Member
Copy link
@Gerodote Does this fix the issue you have in #249?
@Gerodote Does this fix the issue you have in #249?
MultisampledNight approved these changes 2025-12-18 02:50:33 +01:00
MultisampledNight left a comment
Copy link
Nice refactor! :3
Nice refactor! :3
Cyborus commented 2025-12-18 03:05:29 +01:00
Author
Member
Copy link
Thanks?
Thanks?
Arniiiii commented 2025-12-18 10:24:24 +01:00
First-time contributor
Copy link
~/.local/share/forgejo-cli/keys.json :
{
"hosts": {
"example.com/code": {
"type": "Application",
"name": "MyName",
"token": "tokentokentokentokentokentokentokentoken"
}
},
"aliases": {},
"default_ssh": []
}
forgejo-cli was built from branch consistent-host-name .
~/.local/share/forgejo-cli/keys.json : { "hosts": { "example.com/code": { "type": "Application", "name": "MyName", "token": "tokentokentokentokentokentokentokentoken" } }, "aliases": {}, "default_ssh": [] } @Cyborus forgejo-cli was built from branch consistent-host-name .
[image.png](https://codeberg.org/attachments/7b0b855a-dc4f-4d44-a21a-369be950a0de "Click to see "image.png" in a new tab")
19 KiB
Cyborus commented 2025-12-18 14:43:32 +01:00
Author
Member
Copy link
That looks correct to me
That looks correct to me
Cyborus merged commit c928753ec0 into main 2025-12-20 16:50:08 +01:00
Cyborus deleted branch consistent-host-name 2025-12-20 16:50:09 +01:00
Cyborus referenced this pull request from a commit 2025-12-20 16:50:10 +01:00 Merge pull request 'fix: improve host name consistency' (#250) from consistent-host-name into main
Cyborus added this to the v0.4.0 milestone 2026-01-14 01:20:08 +01:00
Cyborus referenced this pull request 2026-01-14 17:44:31 +01:00 fix: strip repo name from detected ssh url #271
Cyborus referenced this pull request from a commit 2026-01-14 17:49:24 +01:00 fix: strip repo name from detected ssh url
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels[ Kind/Breaking Breaking change that won't be backward compatible
](#)[ Kind/Bug Something is not working
](#)[ Kind/Design Discussion about UI/UX design
](#)[ Kind/Documentation Documentation changes
](#)[ Kind/Enhancement Improve existing functionality
](#)[ Kind/Feature New functionality
](#)[ Kind/Security This is security issue
](#)[ Kind/Testing Issue or pull request related to testing
](#)[ Kind/Upstream This is an issue with upstream software (Forgejo) that is probably not our fault
](#)
[ Priority
Critical The priority is critical
](#)[ Priority
High The priority is high
](#)[ Priority
Low The priority is low
](#)[ Priority
Medium The priority is medium
](#)
[ Reviewed
Confirmed Issue has been confirmed
](#)[ Reviewed
Duplicate This issue or pull request already exists
](#)[ Reviewed
Invalid Invalid issue
](#)[ Reviewed
Won't Fix This issue won't be fixed
](#)
[ Status
Abandoned Somebody has started to work on this but abandoned work
](#)[ Status
Blocked Something is blocking this issue or pull request
](#)[ Status
Need More Info Feedback is required to reproduce issue or to continue work
](#)
[ Suspicious
](#)
No labels Kind/Breaking Kind/Bug Kind/Design Kind/Documentation Kind/Enhancement Kind/Feature Kind/Security Kind/Testing Kind/Upstream [ Priority
Critical ](/forgejo-contrib/forgejo-cli/pulls?labels=173012) [ Priority
High ](/forgejo-contrib/forgejo-cli/pulls?labels=173013) [ Priority
Low ](/forgejo-contrib/forgejo-cli/pulls?labels=173015) [ Priority
Medium ](/forgejo-contrib/forgejo-cli/pulls?labels=173014) [ Reviewed
Confirmed ](/forgejo-contrib/forgejo-cli/pulls?labels=173007) [ Reviewed
Duplicate ](/forgejo-contrib/forgejo-cli/pulls?labels=173005) [ Reviewed
Invalid ](/forgejo-contrib/forgejo-cli/pulls?labels=173006) [ Reviewed
Won't Fix ](/forgejo-contrib/forgejo-cli/pulls?labels=173008) [ Status
Abandoned ](/forgejo-contrib/forgejo-cli/pulls?labels=173011) [ Status
Blocked ](/forgejo-contrib/forgejo-cli/pulls?labels=173010) [ Status
Need More Info ](/forgejo-contrib/forgejo-cli/pulls?labels=173009) Suspicious
Milestone
Clear milestone
No items
No milestone v0.4.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
Notifications Subscribe
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
forgejo-contrib/forgejo-cli!250
WritePreview
Loading…
Add table
| Rows | | | Columns | |
CancelOK
Add a link
Url Description Hint: With a URL in your clipboard, you can paste directly into the editor to create a link.
CancelOK
CancelSave
Reference in a new issue
Repository
forgejo-contrib/forgejo-cli
Title
Body
Create issue
No description provided.
Delete branch "consistent-host-name"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
No Yes