Back to Codeberg

fix(pr): check ssh url when finding remote #245

forgejo-contrib-forgejo-cli-pulls-245.md

latest8.5 KB
Original Source

forgejo-contrib/forgejo-cli

Watch20

Star402

Fork

You've already forked forgejo-cli

51

CodeIssues 44Pull requests 8Releases 11Packages 2WikiActivity

fix(pr): check ssh url when finding remote #245

Merged

Cyborusmerged 1 commit from fix/pr-ssh-base-detection into main 2025-12-03 23:03:23 +01:00

Conversation 0Commits 1Files changed 1 +12 -5

Cyborus commented 2025-12-03 22:57:12 +01:00

Member

Copy link

When scanning for the base repo remote, check that the url matches
either the HTTP or SSH clone url of the repo.

It used to check this, but it was removed in bcfb94c316. It wasn't
supposed to be removed.

When scanning for the base repo remote, check that the url matches either the HTTP or SSH clone url of the repo. It used to check this, but it was removed in bcfb94c316. It wasn't supposed to be removed.

Cyborus added 1 commit 2025-12-03 22:57:13 +01:00

fix(pr): check ssh url when finding remote...

All checks were successful

ci/woodpecker/pr/check Pipeline was successful

Details

3ce170de8d

When scanning for the base repo remote, check that the url matches
either the HTTP or SSH clone url of the repo.

It used to check this, but it was removed in[`bcfb94c316`](/forgejo-contrib/forgejo-cli/commit/bcfb94c316). It wasn't
supposed to be removed.

LordMZTE approved these changes 2025-12-03 23:02:43 +01:00

LordMZTE left a comment

Copy link

This fixes the issue I was having!

This fixes the issue I was having!

🎉 1

Cyborus merged commit 04e8258f7e into main 2025-12-03 23:03:23 +01:00

Cyborus referenced this pull request from a commit 2025-12-03 23:03:24 +01:00 Merge pull request 'fix(pr): check ssh url when finding remote' (#245) from fix/pr-ssh-base-detection into main

Cyborus deleted branch fix/pr-ssh-base-detection 2025-12-03 23:03:24 +01:00

Cyborus added this to the v0.4.0 milestone 2026-01-14 01:20:35 +01:00

Sign in to join this conversation.

Reviewers

No reviewers

LordMZTE

Labels

Clear labels[ Kind/Breaking Breaking change that won't be backward compatible

](#)[ Kind/Bug Something is not working

](#)[ Kind/Design Discussion about UI/UX design

](#)[ Kind/Documentation Documentation changes

](#)[ Kind/Enhancement Improve existing functionality

](#)[ Kind/Feature New functionality

](#)[ Kind/Security This is security issue

](#)[ Kind/Testing Issue or pull request related to testing

](#)[ Kind/Upstream This is an issue with upstream software (Forgejo) that is probably not our fault

](#)

[ Priority

Critical The priority is critical

](#)[ Priority

High The priority is high

](#)[ Priority

Low The priority is low

](#)[ Priority

Medium The priority is medium

](#)

[ Reviewed

Confirmed Issue has been confirmed

](#)[ Reviewed

Duplicate This issue or pull request already exists

](#)[ Reviewed

Invalid Invalid issue

](#)[ Reviewed

Won't Fix This issue won't be fixed

](#)

[ Status

Abandoned Somebody has started to work on this but abandoned work

](#)[ Status

Blocked Something is blocking this issue or pull request

](#)[ Status

Need More Info Feedback is required to reproduce issue or to continue work

](#)

[ Suspicious

](#)

No labels Kind/Breaking Kind/Bug Kind/Design Kind/Documentation Kind/Enhancement Kind/Feature Kind/Security Kind/Testing Kind/Upstream [ Priority

Critical ](/forgejo-contrib/forgejo-cli/pulls?labels=173012) [ Priority

High ](/forgejo-contrib/forgejo-cli/pulls?labels=173013) [ Priority

Low ](/forgejo-contrib/forgejo-cli/pulls?labels=173015) [ Priority

Medium ](/forgejo-contrib/forgejo-cli/pulls?labels=173014) [ Reviewed

Confirmed ](/forgejo-contrib/forgejo-cli/pulls?labels=173007) [ Reviewed

Duplicate ](/forgejo-contrib/forgejo-cli/pulls?labels=173005) [ Reviewed

Invalid ](/forgejo-contrib/forgejo-cli/pulls?labels=173006) [ Reviewed

Won't Fix ](/forgejo-contrib/forgejo-cli/pulls?labels=173008) [ Status

Abandoned ](/forgejo-contrib/forgejo-cli/pulls?labels=173011) [ Status

Blocked ](/forgejo-contrib/forgejo-cli/pulls?labels=173010) [ Status

Need More Info ](/forgejo-contrib/forgejo-cli/pulls?labels=173009) Suspicious

Milestone

Clear milestone

No items

No milestone v0.4.0

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

forgejo-contrib/forgejo-cli!245

WritePreview

Loading…

Add table

| Rows | | | Columns | |

CancelOK

Add a link

Url Description Hint: With a URL in your clipboard, you can paste directly into the editor to create a link.

CancelOK

CancelSave

Reference in a new issue

Repository

forgejo-contrib/forgejo-cli

Title

Body

Create issue

No description provided.

Delete branch "fix/pr-ssh-base-detection"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?

No Yes