forgejo-contrib-forgejo-cli-pulls-214.md
Watch20
Star402
Fork
You've already forked forgejo-cli
CodeIssues 44Pull requests 8Releases 11Packages 2WikiActivity
Merged
Cyborusmerged 2 commits from hardcode-client-ids into main 2025-08-30 05:33:13 +02:00
Conversation 0Commits 2Files changed 2 +16 -45
Cyborus commented 2025-08-30 05:24:24 +02:00
Member
Copy link
Removes support for the build-time BUILTIN_CLIENT_IDS environment variable and replaces it with a simple match statement mapping hostnames to client IDs.
The point of that var was so that anyone packaging fj for a package manager would be able to include IDs for any associated instances, i.e. a linux distro that uses Forgejo for its forge.
However this was overkill. Someone packaging it can just patch that file to add their own IDs, and doing it this way prevented oauth from being supported on from-source builds (such as cargo install).
My worry that the client IDs being publicly visible was a risk was also unfounded, and not an issue.
As well, this adds OAuth login support for the following instances:
Removes support for the build-time BUILTIN_CLIENT_IDS environment variable and replaces it with a simple match statement mapping hostnames to client IDs. The point of that var was so that anyone packaging fj for a package manager would be able to include IDs for any associated instances, i.e. a linux distro that uses Forgejo for its forge. However this was overkill. Someone packaging it can just patch that file to add their own IDs, and doing it this way prevented oauth from being supported on from-source builds (such as cargo install). My worry that the client IDs being publicly visible was a risk was also unfounded, and not an issue. --- As well, this adds OAuth login support for the following instances: - v13.next.forgejo.org - git.disroot.org - git.pub.solar - git.kaki87.net - git.gay - git.auxolotl.org - git.lix.systems
Cyborus added 2 commits 2025-08-30 05:24:24 +02:00
feat!: hardcode oauth client ids... 223bdca897
Removes support for the build-time `BUILTIN_CLIENT_IDS` environment
variable and replaces it with a simple match statement mapping hostnames
to client IDs.
The point of that var was so that anyone packaging fj for a package
manager would be able to include IDs for any associated instances, i.e.
a linux distro that uses Forgejo for its forge.
However this was overkill. Someone packaging it can just patch that file
to add their own IDs, and doing it this way prevented oauth from being
supported on from-source builds (such as `cargo build`).
My worry that the client IDs being publicly visible was a risk was also
unfounded, and not an issue.
feat: support more instances for oauth login
All checks were successful
ci/woodpecker/pr/check Pipeline was successful
Cyborus merged commit 083dea2ed3 into main 2025-08-30 05:33:13 +02:00
Cyborus deleted branch hardcode-client-ids 2025-08-30 05:33:14 +02:00
Cyborus referenced this pull request from a commit 2025-08-30 05:33:15 +02:00 Merge pull request 'Hardcode OAuth client IDs' (#214) from hardcode-client-ids into main
Cyborus added this to the v0.4.0 milestone 2025-12-01 17:04:50 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels[ Kind/Breaking Breaking change that won't be backward compatible
](#)[ Kind/Bug Something is not working
](#)[ Kind/Design Discussion about UI/UX design
](#)[ Kind/Documentation Documentation changes
](#)[ Kind/Enhancement Improve existing functionality
](#)[ Kind/Feature New functionality
](#)[ Kind/Security This is security issue
](#)[ Kind/Testing Issue or pull request related to testing
](#)[ Kind/Upstream This is an issue with upstream software (Forgejo) that is probably not our fault
](#)
[ Priority
Critical The priority is critical
](#)[ Priority
High The priority is high
](#)[ Priority
Low The priority is low
](#)[ Priority
Medium The priority is medium
](#)
[ Reviewed
Confirmed Issue has been confirmed
](#)[ Reviewed
Duplicate This issue or pull request already exists
](#)[ Reviewed
Invalid Invalid issue
](#)[ Reviewed
Won't Fix This issue won't be fixed
](#)
[ Status
Abandoned Somebody has started to work on this but abandoned work
](#)[ Status
Blocked Something is blocking this issue or pull request
](#)[ Status
Need More Info Feedback is required to reproduce issue or to continue work
](#)
[ Suspicious
](#)
No labels Kind/Breaking Kind/Bug Kind/Design Kind/Documentation Kind/Enhancement Kind/Feature Kind/Security Kind/Testing Kind/Upstream [ Priority
Critical ](/forgejo-contrib/forgejo-cli/pulls?labels=173012) [ Priority
High ](/forgejo-contrib/forgejo-cli/pulls?labels=173013) [ Priority
Low ](/forgejo-contrib/forgejo-cli/pulls?labels=173015) [ Priority
Medium ](/forgejo-contrib/forgejo-cli/pulls?labels=173014) [ Reviewed
Confirmed ](/forgejo-contrib/forgejo-cli/pulls?labels=173007) [ Reviewed
Duplicate ](/forgejo-contrib/forgejo-cli/pulls?labels=173005) [ Reviewed
Invalid ](/forgejo-contrib/forgejo-cli/pulls?labels=173006) [ Reviewed
Won't Fix ](/forgejo-contrib/forgejo-cli/pulls?labels=173008) [ Status
Abandoned ](/forgejo-contrib/forgejo-cli/pulls?labels=173011) [ Status
Blocked ](/forgejo-contrib/forgejo-cli/pulls?labels=173010) [ Status
Need More Info ](/forgejo-contrib/forgejo-cli/pulls?labels=173009) Suspicious
Milestone
Clear milestone
No items
No milestone v0.4.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
Notifications Subscribe
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
forgejo-contrib/forgejo-cli!214
WritePreview
Loading…
Add table
| Rows | | | Columns | |
CancelOK
Add a link
Url Description Hint: With a URL in your clipboard, you can paste directly into the editor to create a link.
CancelOK
CancelSave
Reference in a new issue
Repository
forgejo-contrib/forgejo-cli
Title
Body
Create issue
No description provided.
Delete branch "hardcode-client-ids"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
No Yes