forgejo-contrib-forgejo-cli-issues-382.md
Watch20
Star402
Fork
You've already forked forgejo-cli
CodeIssues 44Pull requests 8Releases 11Packages 2WikiActivity
core.editor for the editor #382Closed
opened 2026-03-22 23:04:39 +01:00 by florian-obernberger · 2 comments
florian-obernberger commented 2026-03-22 23:04:39 +01:00
Contributor
Copy link
Use the git config’s core.editor value over $EDITOR.
I was wondering why doesn’t fj just use the core.editor defined in the git config?
Personally that is what I’d expect, as it is a tool meant to interact with git and also would save the hassle of having to set up the $EDITOR variable specifically for fj.
I also already have a working implementation ready which I can open a PR for, I did however first want to check-in if this is a feature that would be wanted or not :)
core.editor value over $EDITOR. ### Motivation I was wondering why doesn’t fj just use the core.editor defined in the git config? Personally that is what I’d expect, as it is a tool meant to interact with git and also would save the hassle of having to set up the $EDITOR variable specifically for fj. I also already have a working implementation ready which I can open a PR for, I did however first want to check-in if this is a feature that would be wanted or not :) ### Code of Conduct - [x] I agree to act in accordance with the CoC & AI Agreement. - [x] This issue was not generated by an LLM, even in part.florian-obernberger added the Kind/Feature label 2026-03-22 23:04:44 +01:00
Cyborus changed title from ** use git conig's ** to use git config's core.editor for the editorcore.editor for the editor 2026-03-22 23:54:00 +01:00
Cyborus commented 2026-03-23 00:02:39 +01:00
Member
Copy link
That makes sense to me. My config doesn't have core.editor set, so I think it should first look for core.editor, but fallback to $EDITOR.
That makes sense to me. My config doesn't have core.editor set, so I think it should first look for core.editor, but fallback to $EDITOR.
florian-obernberger commented 2026-03-24 09:10:08 +01:00
Author
Contributor
Copy link
Yes exactly! First check for the core.editor variable and if not fall back to the $EDITOR based one, which should give everyone the option to choose what they want :)
I'll migrate my code to the latest version of your code base and then create a PR!
Yes exactly! First check for the core.editor variable and if not fall back to the $EDITOR based one, which _should_ give everyone the option to choose what they want :) I'll migrate my code to the latest version of your code base and then create a PR!
👍 1
florian-obernberger referenced this issue 2026-03-24 09:41:21 +01:00
feat: use git's core.editor if available #385
LordMZTE closed this issue 2026-03-25 20:40:36 +01:00
stalecontext referenced this issue from stalecontext/forgejo-cli-plus 2026-03-31 14:17:29 +02:00 Upstream sync 2026-03-31 #48
stalecontext referenced this issue from a commit 2026-03-31 15:38:05 +02:00 Upstream sync 2026-03-31 (#48)
Sign in to join this conversation.
No Branch/Tag specified
main
renovate/lock-file-maintenance
renovate/serde-saphyr-0.x
docs/contributing
no-port-in-refspec
login/v16.next.forgejo.org
crates-io-publish
0.5.x
compile-time-fluent
0.4.x
localization-alias-demo
api_url_field
v0.5.0
v0.4.1
v0.4.0
v0.3.0
v0.2.0
v0.1.1
v0.1.0
v0.0.4
v0.0.3
v0.0.2
v0.0.1
Labels
Clear labels[ Kind/Breaking Breaking change that won't be backward compatible
](#)[ Kind/Bug Something is not working
](#)[ Kind/Design Discussion about UI/UX design
](#)[ Kind/Documentation Documentation changes
](#)[ Kind/Enhancement Improve existing functionality
](#)[ Kind/Feature New functionality
](#)[ Kind/Security This is security issue
](#)[ Kind/Testing Issue or pull request related to testing
](#)[ Kind/Upstream This is an issue with upstream software (Forgejo) that is probably not our fault
](#)
[ Priority
Critical The priority is critical
](#)[ Priority
High The priority is high
](#)[ Priority
Low The priority is low
](#)[ Priority
Medium The priority is medium
](#)
[ Reviewed
Confirmed Issue has been confirmed
](#)[ Reviewed
Duplicate This issue or pull request already exists
](#)[ Reviewed
Invalid Invalid issue
](#)[ Reviewed
Won't Fix This issue won't be fixed
](#)
[ Status
Abandoned Somebody has started to work on this but abandoned work
](#)[ Status
Blocked Something is blocking this issue or pull request
](#)[ Status
Need More Info Feedback is required to reproduce issue or to continue work
](#)
[ Suspicious
](#)
No labels Kind/Breaking Kind/Bug Kind/Design Kind/Documentation Kind/Enhancement Kind/Feature Kind/Security Kind/Testing Kind/Upstream [ Priority
Critical ](/forgejo-contrib/forgejo-cli/issues?labels=173012) [ Priority
High ](/forgejo-contrib/forgejo-cli/issues?labels=173013) [ Priority
Low ](/forgejo-contrib/forgejo-cli/issues?labels=173015) [ Priority
Medium ](/forgejo-contrib/forgejo-cli/issues?labels=173014) [ Reviewed
Confirmed ](/forgejo-contrib/forgejo-cli/issues?labels=173007) [ Reviewed
Duplicate ](/forgejo-contrib/forgejo-cli/issues?labels=173005) [ Reviewed
Invalid ](/forgejo-contrib/forgejo-cli/issues?labels=173006) [ Reviewed
Won't Fix ](/forgejo-contrib/forgejo-cli/issues?labels=173008) [ Status
Abandoned ](/forgejo-contrib/forgejo-cli/issues?labels=173011) [ Status
Blocked ](/forgejo-contrib/forgejo-cli/issues?labels=173010) [ Status
Need More Info ](/forgejo-contrib/forgejo-cli/issues?labels=173009) Suspicious
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
Notifications Subscribe
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
forgejo-contrib/forgejo-cli#382
WritePreview
Loading…
Add table
| Rows | | | Columns | |
CancelOK
Add a link
Url Description Hint: With a URL in your clipboard, you can paste directly into the editor to create a link.
CancelOK
CancelSave
Reference in a new issue
Repository
forgejo-contrib/forgejo-cli
Title
Body
Create issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
No Yes