Back to Chromium

Pinpoint & Gerrit Evaluation Workflow

agents/skills/chrome-performance-optimizer/references/pinpoint_workflow.md

154.0.8011.21.9 KB
Original Source

Pinpoint & Gerrit Evaluation Workflow

Guide for running A/B try jobs on M1 Mac hardware and evaluating statistical significance.


1. Uploading CL to Gerrit

Ensure the change is committed with clean descriptions and tags:

bash
git cl upload -m "Optimization summary" --cq-dry-run

Verify the Gerrit Change ID / Issue number via:

bash
git cl issue

2. Launching Pinpoint Try Job

Run Pinpoint with 150 iterations on Apple Silicon (m1) bot config for Speedometer 3 (sp3):

bash
pp c -c m1 -t sp3 -r 150
  • -c m1: Target M1 hardware bot.
  • -t sp3: Target Speedometer 3 benchmark template.
  • -r 150: 150 repetitions per variant for robust statistical confidence.
  • --exp-patch auto: Automatically attaches the current branch's Gerrit patch.

3. Polling and Evaluating Pinpoint Results

Check the comparison table and statistical significance:

bash
pp s <JOB_ID>

Evaluation Criteria:

  1. Statistical Significance: Pinpoint highlights significant changes with p < 0.05 and confidence intervals.
  2. Overall Geometric Mean: Check if the top-level benchmark score increased (+X.X%).
  3. Sub-story Regressions: Ensure no major sub-story regresses significantly.

Decision Actions:

  • Winner (Keep & Propose): If overall score is improved with statistically significant sub-metrics and no critical regressions, maintain the CL, post results in the description, and send to reviewers.
  • Neutral / Regressed (Abandon): If the change shows no measurable improvement or causes regressions, abandon the CL:
    bash
    git cl abandon -m "Pinpoint try job showed no statistically significant improvement."