Back to Chromium

Automated Review Protocol: Accessibility Cleanup

agents/projects/code-health/accessibility-cleanup/references/automated_review.md

152.0.7927.01.3 KB
Original Source

Automated Review Protocol: Accessibility Cleanup

Use this prompt when delegating a final review of an accessibility cleanup patch to the generalist sub-agent.

Review Prompt

Delegate the review to the generalist sub-agent with this exact prompt:

"Follow the Shared Automated Review Protocol in ../../hub/references/shared_automated_review.md.

In addition to the generic checks, you MUST evaluate the patch against these Specific Cleanup Rules for Accessibility Cleanup:

  • No Regressions: Ensure that the end-user behavior has no regressions and is expected to improve from more accurate API usage.
  • Duplicate Code: Check that we are not creating duplicate code with a reusable component or utility method/class that exists in the codebase.
  • Unused Strings: Are there any strings that are now unused in the code? If so, ensure that the strings have been removed along with their corresponding png sha1 files if such files exist. For example, when removing the string example_string, which is declared in the file: components/feature_strings.grdp with the name IDS_EXAMPLE_STRING, there may be a corresponding file: components/feature_strings_grdp/IDS_EXAMPLE_STRING.png.sha1, which should be deleted."