chrome/browser/prefs/README.md
Prefs is meant to store lightweight state that reflects user preferences (e.g.
chrome://settings, position of windows on last exit, etc.). Browser-wide prefs
are stored in Local State (g_browser_process->local_state()) and per-profile
prefs are stored in Preferences (Profile::GetPrefs()). The PrefService API
is used to read/write registered prefs. Prefs are saved as JSON and any
modification forces serialization of the entire JSON dictionary. The
LOSSY_PREF flag can be used when registering a pref to indicate that
modifications to it shouldn't schedule a write (in which case the write will be
bundled with the next change that does schedule a write or wait until the final
write on shutdown; the update is lost in case of a crash).
Prefs are not for:
LOSSY_PREF flag)pref_names.cc local to your component (typically inside a prefs:: C++
namespace nested in your component's namespace)RegisterLocalState() or
RegisterProfilePrefs() as appropriate.SYNCABLE_PREF flags when registering it and add it to the syncable
prefs database (see components/sync_preferences/README.md for details):
Use PrefService::Get*() APIs on g_browser_process->local_state() or
Profile::GetPrefs(), as appropriate, to read/write your pref.
Reading (GetValue()) will query the following PrefStore's in order, the
first one with a value will win (implemented in PrefValueStore):
Writing (SetValue()) will always write to User Prefs (the only modifiable
store). As such, if a value is already set in a PrefStore with precedence over
User Prefs, re-reading the value might not return the value you just set.
Visually such settings are typically grayed out to prevent confusing the user
but nothing prevents C++ from setting a user pref that doesn't take effect.
To add a new PrefStore in the precedence order, see PrefStoreType in
PrefValueStore.
Most deleted prefs should be left in a delete-self state for 1 year to help avoid leaving unused text in JSON files storing User Prefs. To avoid leaving a bunch of TODOs and pinging owners to cleanup, you will be asked to follow-up your CL with another CL that removes 1+ year old deletions; someone else will clean up after you in 1 year.
RegisterProfilePrefsForMigration() or
RegisterLocalStatePrefsForMigration() as appropriate.SYNCABLE_PREF flag, remove it now
(syncing the deletion would break clients on older versions).ClearPref() call in MigrateObsoleteProfilePrefs() or
MigrateObsoleteLocalStatePrefs() as appropriate, with today's date
(MM/YYYY) in a comment.ClearPref() calls in
browser_prefs.cc; someone else will clean up after you in 1 year.If the pref is exposed via policy, you will need to mark the policy as deprecated by following the steps in add_new_policy.md. Deleting the pref logic (steps above) will then need to wait a few milestones.
Note: If the pref was only exposed as a policy in the Managed Prefs (with no UI to allow an end-user to adjust the pref) then there is no need to set the pref to a delete-self state using the steps above, because the pref will never have been written to User Prefs JSON.
Instead of merely deleting a pref you might want to run migration code from an
old to a new pref. This uses the same hooks as deletion and will be left in
place for 1 year as well. MigrateObsoleteLocalStatePrefs() is invoked as part
of initializing g_browser_process and MigrateObsoleteProfilePrefs() is
invoked as part of initializing each Profile. In both cases this is before
each PrefService is query-able by the rest of //chrome, your code can
therefore assume the migration has taken place if it's accessing the
PrefService via an initialized BrowserProcess or Profile.
Note that this code in browser_prefs.cc does not run on iOS, so if you're
migrating a pref that also is used on iOS, then the pref may also need to be
migrated or cleared specifically for iOS as well. This could be by doing the
migration in feature code that's called by all platforms instead of here, or by
calling migration code in the appropriate place for iOS specifically, e.g.
ios/chrome/browser/shared/model/prefs/browser_prefs.mm.
As per deleting an old pref, if the old pref is also a policy, you will need to mark it deprecated for a few milestones first as described in add_new_policy.md.
Migration code will want to read the old pref using
PrefService::GetUserPrefValue() (as opposed to PrefService::Get*()). This
will ensure that the user configured value is migrated instead of a value from a
higher-priority PrefStore like the one containing Managed Prefs. It also
covers a second case: If no explicit value is set in any PrefStore,
GetValue() returns the default value. You don't want to write that to the
target location of your migration as that would prevent future changes to
default or recommended prefs from taking effect.
If non-User PrefStores need to keep supporting the old pref for a grace period,
you will need to either:
!PrefService::FindPreference(old_pref_name)->IsUserModifiable()); orPrefStores automatically map the old pref name to
the new pref name. There are ad-hoc examples of this in the codebase but this
is generally trickier. If you do add/find a generic way of doing this, please
augment this documentation :).