ContextQMD
Back to Cal

TODO

packages/lib/service/TODO.md

6.2.02.5 KB
Original Source

BUGS

  • Test Attribute Edit. It seems to be doing weird things with the ids.

TODO

  • Sync from Okta to user could be in core namespace urn:ietf:params:scim:schemas:core:2.0:User and we might need to ask for the namespace to sync from.
  • Deleting a sub-option, should remove it from option-group?
  • Locked attribute are free to have its options completely reset by SCIM
  • Unlocked attribute shouldn't get updates from SCIM but in case they still do, we follow this strategy
    • If attribute from SCIM, doesn't exist on user, we allow it to be freely set on the user
    • If attribute from SCIM, exists on user
      • It is a single select or a non-enum attribute, we don't let it be overridden and completely ignore the SCIM update for that attribute
      • It is a multi select, we remove the options that were created from SCIM and add the new options from SCIM. AttributeToUser.createdByDSyncId is set to SCIM directorySync id for those options. It allows both SCIM set and User set options to be assigned to the User.
    • The options created by SCIM aren't deletable from Cal.com UI. User can only remove options created by Cal.com i.e. where AttributeToUser.createdByDSyncId is null.
  • Restrict setting values
    • Allow setting any value for non enum attributes(i.e. non-dropdown attributes)
    • Restrict setting values for enum attributes(i.e. dropdown attributes)
  • AttributeAssignment within App
    • For locked field, shouldn't be able to delete an assignment or add a new assignment.
    • For unlocked field, should be able to delete the assignments owned by cal.com users only. Should be able to add new assignments for any user.
  • Support array update
  • Ensure the already existing assignment(with same value) isn't recreated. To ensure weights aren't reset.
    • Locked attributes
    • Unlocked attributes

Test

  • Okta to Cal.com
    1. Add a user with attribute
    2. Simulate a failure in adding the user
    • Failure could be in user creation or attribute assignment creation
    1. Remove the user and Re-add the user and see if it's correctly synced.
    • Try removing a locked attribute assignment from a user.

Documentation

Okta stuff

  • Removing the assignment of a user from the app, doesn't remove the user from Cal.com