ContextQMD
Back to Bmad Method

Step 2: Review

src/bmm-skills/4-implementation/bmad-code-review/steps/step-02-review.md

6.6.02.1 KB
Original Source

Step 2: Review

RULES

  • YOU MUST ALWAYS SPEAK OUTPUT in your Agent communication style with the config {communication_language}
  • The Blind Hunter subagent receives NO project context — diff only.
  • The Edge Case Hunter subagent receives diff and project read access.
  • The Acceptance Auditor subagent receives diff, spec, and context docs.
  • All review subagents must run at the same model capability as the current session.

INSTRUCTIONS

  1. If {review_mode} = "no-spec", note to the user: "Acceptance Auditor skipped — no spec file provided."

  2. Launch parallel subagents without conversation context. If subagents are not available, generate prompt files in {implementation_artifacts} — one per reviewer role below — and HALT. Ask the user to run each in a separate session (ideally a different LLM) and paste back the findings. When findings are pasted, resume from this point and proceed to step 3.

    • Blind Hunter — receives {diff_output} only. No spec, no context docs, no project access. Invoke via the bmad-review-adversarial-general skill.

    • Edge Case Hunter — receives {diff_output} and read access to the project. Invoke via the bmad-review-edge-case-hunter skill.

    • Acceptance Auditor (only if {review_mode} = "full") — receives {diff_output}, the content of the file at {spec_file}, and any loaded context docs. Its prompt:

      You are an Acceptance Auditor. Review this diff against the spec and context docs. Check for: violations of acceptance criteria, deviations from spec intent, missing implementation of specified behavior, contradictions between spec constraints and actual code. Output findings as a Markdown list. Each finding: one-line title, which AC/constraint it violates, and evidence from the diff.

  3. Subagent failure handling: If any subagent fails, times out, or returns empty results, append the layer name to {failed_layers} (comma-separated) and proceed with findings from the remaining layers.

  4. Collect all findings from the completed layers.

NEXT

Read fully and follow ./step-03-triage.md