Release Gate: be-i9e2 — bd dolt push no-push unit test

Branch: feat/be-3w6-be-0c8-nopush-dolt Tip commit: 6a8c547fc5ad63c257272656ab09259c1ce20927 Deploy bead: be-wfb5 Source bead: be-i9e2 Review bead: be-lijh (PASS) Date: 2026-06-07

Gate Checklist

#	Criterion	Result	Evidence
1	Review PASS present	PASS	be-lijh reviewed `6a8c547fc` on this branch; verdict PASS. Findings: style/security [info], spec [pass×2], tests [pass]. No [high] findings.
2	Acceptance criteria met	PASS	See below
3	Tests pass	PASS	See below
4	No high-severity findings open	PASS	Review notes contain [info] and [nit] only; zero [high] findings
5	Final branch is clean	PASS	`git status` clean on `feat/be-3w6-be-0c8-nopush-dolt`; no uncommitted changes
6	Branch diverges cleanly from main	PASS	`git merge-tree` reports 0 conflicts with `origin/main`
7	Single feature theme	PASS	All 5 commits are about the no-push guard for `bd dolt push/pull`. Removing any one commit from main would leave the others working independently — but they all form one coherent guard + test bundle.

Criterion 2: Acceptance Criteria

From be-i9e2:

Focused test asserting bd dolt push exits 0 with skip message when no-push:true — TestNoPushSkipsDoltPush (cmd/bd/dolt_test.go:1506) asserts fake.pushCalled == false and output contains "skipping push" when BD_NO_PUSH=true.
Does NOT call the store's Push() — minimalPushStore.pushCalled verified false in the same test.
Mirrors TestNoPushDoesNotSkipDoltPull pattern — uses same saveAndRestoreGlobals(t) / t.Setenv / config.ResetForTesting() structure.

Criterion 3: Test Results

$ go test ./cmd/bd/ -run "TestNoPushSkipsDoltPush|TestNoPushDoesNotSkipDoltPull" -v -count=1
WARN: Docker not available, skipping Dolt tests
=== RUN   TestNoPushSkipsDoltPush
--- PASS: TestNoPushSkipsDoltPush (0.00s)
=== RUN   TestNoPushDoesNotSkipDoltPull
--- PASS: TestNoPushDoesNotSkipDoltPull (0.00s)
PASS
ok  	github.com/steveyegge/beads/cmd/bd	0.104s

Full cmd/bd suite run: some tests fail due to pre-existing environment isolation issues in the GC rig (live beads DB at /home/jaword/.beads interferes with tests that expect no beads present). The same failures are confirmed present on origin/main directly — not introduced by this branch. The reviewer ran the full dolt suite on a clean environment and confirmed PASS with no regressions.

Commits on branch (ahead of origin/main)

SHA	Message
`6a8c547`	test(dolt): add TestNoPushSkipsDoltPush for push guard coverage (be-i9e2)
`78e882286`	fix(no-push): add missing context and storage imports to dolt_test.go
`7836510b0`	fix(no-push): remove pull guard from bd dolt pull (be-ve2x6)
`da82de490`	fix(no-push): anchor stripDoltPushReferences to prevent 4-space indent false match
`56f7848c7`	feat(no-push): guard dolt push/pull and strip push from rendered templates