external/ag-shared/prompts/skills/plan-implementation-review/SKILL.md
You are an implementation reviewer for AG Charts. Review how complete plan execution is by tracking progress, identifying gaps, and validating quality.
User provides one of:
/plan-implementation-review path/to/plan.md/plan-implementation-review (looks for recent plans)Optional flags:
--quick - Fast progress check (2 agents)--thorough - Comprehensive review (default, 4 agents)Load sub-documents progressively based on the review mode and phase.
| Document | Purpose | When to Load |
|---|---|---|
agent-prompts.md | Agent prompt templates for all modes | Phase 1 (agent launch) |
output-format.md | Report template and output structure | Phase 3 (report generation) |
discovered-work.md | Discovered Work Protocol for sub-agents | Include in all sub-agent prompts |
The discovered-work.md is shared with the plan-review skill.
Load original plan file:
# If explicit path provided, use it
# Otherwise, check common locations:
find "${CLAUDE_CONFIG_DIR:-$HOME/.claude}"/plans node_modules/.cache/plans -name "*.md" -mtime -7 2>/dev/null | head -10
Determine review mode:
| Flag | Mode | Agents | Use Case |
|---|---|---|---|
--quick | Quick | 2 | Fast progress check |
--thorough (default) | Thorough | 4 | Comprehensive validation |
Detect git changes since plan creation:
# Get plan creation/modification time
plan_date=$(stat -f %m "$PLAN_FILE" 2>/dev/null || stat -c %Y "$PLAN_FILE")
# Find commits since plan was created
git log --oneline --since="@$plan_date" --all
# Get diff of all changes
git diff --name-only HEAD~N # N = number of commits since plan
# Get detailed changes for each file
git diff HEAD~N -- path/to/file.ts
Extract core intent from plan:
Critical: Understanding intent is essential for assessing implementation quality.
This intent guides assessment of whether implementation serves the goal, not just completes tasks.
Identify modified files and their relationship to plan:
Cross-reference:
Launch analysis agents based on mode. Load .rulesync/skills/plan-implementation-review/agent-prompts.md for prompt templates.
Include the Discovered Work Protocol from .rulesync/skills/plan-review/discovered-work.md in all sub-agent prompts.
┌─────────────────────────────────────────────────────────────┐
│ QUICK MODE AGENTS │
├─────────────────────────────────────────────────────────────┤
│ 1. Progress Auditor │
│ - Maps plan steps to code changes │
│ - Calculates completion percentage │
│ - Identifies gaps between plan and implementation │
├─────────────────────────────────────────────────────────────┤
│ 2. Verification Checker │
│ - Test coverage status │
│ - Build status │
│ - Lint/type check status │
└─────────────────────────────────────────────────────────────┘
┌─────────────────────────────────────────────────────────────┐
│ THOROUGH MODE AGENTS │
├─────────────────────────────────────────────────────────────┤
│ 1. Progress Auditor │
│ 2. Gap Detector │
│ 3. Intent & Quality Validator (CRITICAL) │
│ 4. Test Coverage Reviewer │
└─────────────────────────────────────────────────────────────┘
Correlate plan steps with implementation evidence.
Map to Git Commits:
# For each plan step, find related commits
git log --oneline --grep="step keyword" --all
git log --oneline -- "affected/file/path.ts"
Map to Modified Files:
For each step in the plan:
Check Test Results (if available):
yarn nx test ag-charts-community --testPathPattern="relevant-test"
yarn nx build:types ag-charts-community
Check Build Status (if available):
yarn nx build:types ag-charts-community ag-charts-enterprise
yarn nx lint ag-charts-community ag-charts-enterprise
Load .rulesync/skills/plan-implementation-review/output-format.md for the report template.
TaskList, triage, include in report# Thorough review (default)
/plan-implementation-review
# Quick progress check
/plan-implementation-review --quick
# Explicit plan file
/plan-implementation-review path/to/plan.md
/plan-review to validate the plan/plan-implementation-review periodicallyReview results are cached for tracking progress over time:
node_modules/.cache/plan-implementation-reviews/
├── {plan-name}-{timestamp}.json # Raw agent findings
├── {plan-name}-progress.json # Progress tracking over time
├── {plan-name}-report.md # Generated report
└── metadata.json # Review session metadata